Bug 43222 - Setting empty document schemes on the WKContext shouldn't start the WebProcess
Summary: Setting empty document schemes on the WKContext shouldn't start the WebProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-29 17:32 PDT by Brady Eidson
Modified: 2010-07-29 17:40 PDT (History)
0 users

See Also:

Attachments
Patch (2.55 KB, patch)
2010-07-29 17:33 PDT, Brady Eidson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2010-07-29 17:32:42 PDT 
Setting empty document schemes on the WKContext shouldn't start the WebProcess
Comment 1 Brady Eidson 2010-07-29 17:33:55 PDT 
Created attachment 63016 [details]
Patch
Comment 2 Sam Weinig 2010-07-29 17:39:43 PDT 
Comment on attachment 63016 [details]
Patch

>  
>  void WebContext::registerURLSchemeAsEmptyDocument(const String& urlScheme)
>  {
> -    ensureWebProcess();
> +    if (!hasValidProcess()) {
> +        m_schemesToRegisterAsEmptyDocument.add(urlScheme);

I think we always want to store these for the crashing case and we shouldn't clear them after sending. 

Otherwise, r=me.
Comment 3 Brady Eidson 2010-07-29 17:40:54 PDT 
Committed r64324: <http://trac.webkit.org/changeset/64324>