Bug 43215 - Implement NPN_Enumerate
Summary: Implement NPN_Enumerate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-29 15:08 PDT by Anders Carlsson
Modified: 2010-07-29 15:22 PDT (History)
1 user (show)

See Also:


Attachments
Patch (10.03 KB, patch)
2010-07-29 15:13 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-07-29 15:08:04 PDT
Implement NPN_Enumerate
Comment 1 Anders Carlsson 2010-07-29 15:13:54 PDT
Created attachment 62996 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-29 15:16:32 PDT
Attachment 62996 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/Plugins/NPJSObject.cpp:314:  NPJSObject::NP_Enumerate is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2010-07-29 15:22:43 PDT
Committed r64312: <http://trac.webkit.org/changeset/64312>