Bug 43206 - Ask a canvas' rendering context if it is accelerated instead tying it directly to webgl
Summary: Ask a canvas' rendering context if it is accelerated instead tying it directl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-29 12:58 PDT by James Robinson
Modified: 2010-07-29 14:35 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.07 KB, patch)
2010-07-29 13:01 PDT, James Robinson 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2010-07-29 12:58:47 PDT 
Ask a canvas' rendering context if it is accelerated instead tying it directly to webgl
Comment 1 James Robinson 2010-07-29 13:01:02 PDT 
Created attachment 62978 [details]
Patch
Comment 2 Simon Fraser (smfr) 2010-07-29 13:10:04 PDT 
Comment on attachment 62978 [details]
Patch

>  #if ENABLE(3D_CANVAS)
>      HTMLCanvasElement* canvas = static_cast<HTMLCanvasElement*>(node());
> -    return canvas && canvas->is3D();
> +    return canvas && canvas->renderingContext() && canvas->renderingContext()->isAccelerated();

No need for the #if ENABLE(3D_CANVAS) any more?
Comment 3 James Robinson 2010-07-29 13:37:50 PDT 
True, I'll get rid of the #ifs.
Comment 4 James Robinson 2010-07-29 14:35:47 PDT 
Committed r64308: <http://trac.webkit.org/changeset/64308>