RESOLVED FIXED Bug 43196
Java applets should be blocked when plugins are blocked (in Chromium, at least)
https://bugs.webkit.org/show_bug.cgi?id=43196
Summary Java applets should be blocked when plugins are blocked (in Chromium, at least)
Bernhard Bauer
Reported 2010-07-29 09:41:56 PDT
After removing click-to-play in Chromium, Java applets aren't blocked when plugins are disabled in the content setting (http://crbug.com/50506). Turns out, this was already broken some time before click-to-play landed, namely since http://trac.webkit.org/changeset/60178. Even before that, applets were only blocked pretty much as a side effect of the code removed in that revision. Patch forthcoming.
Attachments
Check if plugins are allowed before creating a Java applet (1.30 KB, patch)
2010-07-29 09:49 PDT, Bernhard Bauer
no flags
Bernhard Bauer
Comment 1 2010-07-29 09:49:01 PDT
Created attachment 62964 [details] Check if plugins are allowed before creating a Java applet
Bernhard Bauer
Comment 2 2010-07-29 09:53:53 PDT
Bonus: with this patch, you also get the plugins blocked bubble (you didn't before).
Darin Adler
Comment 3 2010-07-29 11:23:22 PDT
Comment on attachment 62964 [details] Check if plugins are allowed before creating a Java applet This is not a Chromium-specific patch. Do all platforms want to block Java if plug-ins are blocked?
Darin Fisher (:fishd, Google)
Comment 4 2010-07-29 14:25:13 PDT
Comment on attachment 62964 [details] Check if plugins are allowed before creating a Java applet R+CQ=me No other ports override allowPlugins to block plugins on a per-frame basis. Other ports use the global settings to block Java, etc. It seems appropriate to me to treat Java as a plugin. (It is an ordinary NPAPI plugin these days, at least on Windows.)
WebKit Commit Bot
Comment 5 2010-07-29 15:09:58 PDT
Comment on attachment 62964 [details] Check if plugins are allowed before creating a Java applet Clearing flags on attachment: 62964 Committed r64311: <http://trac.webkit.org/changeset/64311>
WebKit Commit Bot
Comment 6 2010-07-29 15:10:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.