Bug 43195 - WebKit2 often says "plugin path" when it means "plugin directory"
Summary: WebKit2 often says "plugin path" when it means "plugin directory"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks: 43189
  Show dependency treegraph
 
Reported: 2010-07-29 09:22 PDT by Adam Roben (:aroben)
Modified: 2010-07-29 09:41 PDT (History)
3 users (show)

See Also:


Attachments
Patch (12.31 KB, patch)
2010-07-29 09:27 PDT, Adam Roben (:aroben)
sullivan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-07-29 09:22:08 PDT
WebKit2 often says "plugin path" when it means "plugin directory"
Comment 1 Adam Roben (:aroben) 2010-07-29 09:27:31 PDT
Created attachment 62957 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-29 09:28:30 PDT
Attachment 62957 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKContext.cpp:108:  _WKContextSetAdditionalPluginDirectory is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Roben (:aroben) 2010-07-29 09:41:13 PDT
Committed r64286: <http://trac.webkit.org/changeset/64286>