RESOLVED FIXED 43193
Initialize all members of NPClass struct 
https://bugs.webkit.org/show_bug.cgi?id=43193
Summary Initialize all members of NPClass struct
Csaba Osztrogonác
Reported 2010-07-29 09:01:12 PDT
We should initialize all members of NPClass struct to avoid gcc warnings. Warnings on Qt bots: /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:119: warning: missing initializer for member ‘NPClass::removeProperty’ /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:119: warning: missing initializer for member ‘NPClass::enumerate’ /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:119: warning: missing initializer for member ‘NPClass::construct’
Attachments
proposed patch (1.01 KB, patch)
2010-07-29 09:05 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2010-07-29 09:05:14 PDT
Created attachment 62953 [details] proposed patch Members of "static NPClass pluginClass" are initialized with zeros by crt0. We can do it explicitly to avoid gcc warnings.
Csaba Osztrogonác
Comment 2 2010-07-29 09:36:43 PDT
Comment on attachment 62953 [details] proposed patch Clearing flags on attachment: 62953 Committed r64285: <http://trac.webkit.org/changeset/64285>
Csaba Osztrogonác
Comment 3 2010-07-29 09:38:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.