Bug 43193 - Initialize all members of NPClass struct
Summary: Initialize all members of NPClass struct
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 43191
  Show dependency tree / graph
 
Reported: 2010-07-29 09:01 PDT by Csaba Osztrogonác
Modified: 2010-07-29 09:38 PDT (History)
0 users

See Also:

Attachments
proposed patch (1.01 KB, patch)
2010-07-29 09:05 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-07-29 09:01:12 PDT 
We should initialize all members of NPClass struct to avoid gcc warnings.

Warnings on Qt bots:
/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:119: warning: missing initializer for member ‘NPClass::removeProperty’
/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:119: warning: missing initializer for member ‘NPClass::enumerate’
/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:119: warning: missing initializer for member ‘NPClass::construct’
Comment 1 Csaba Osztrogonác 2010-07-29 09:05:14 PDT 
Created attachment 62953 [details]
proposed patch

Members of "static NPClass pluginClass" are initialized with zeros by crt0.
We can do it explicitly to avoid gcc warnings.
Comment 2 Csaba Osztrogonác 2010-07-29 09:36:43 PDT 
Comment on attachment 62953 [details]
proposed patch

Clearing flags on attachment: 62953

Committed r64285: <http://trac.webkit.org/changeset/64285>
Comment 3 Csaba Osztrogonác 2010-07-29 09:38:31 PDT 
All reviewed patches have been landed.  Closing bug.