Bug 43192 - Warning fix on platforms where XP_MACOSX is undefined.
Summary: Warning fix on platforms where XP_MACOSX is undefined.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 43191
  Show dependency tree / graph
 
Reported: 2010-07-29 08:46 PDT by Csaba Osztrogonác
Modified: 2010-07-29 09:14 PDT (History)
0 users

See Also:

Attachments
accidentally uploaded (1.36 KB, patch)
2010-07-29 08:48 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
proposed patch (1.71 KB, patch)
2010-07-29 08:51 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-07-29 08:46:35 PDT 
Warnings on Qt buildbot:

/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.h:28:5: warning: "XP_MACOSX" is not defined
/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.h:69:5: warning: "XP_MACOSX" is not defined
/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/WebKitTools/DumpRenderTree/TestNetscapePlugIn/PluginObject.h:83:5: warning: "XP_MACOSX" is not defined
Comment 1 Csaba Osztrogonác 2010-07-29 08:48:52 PDT 
Created attachment 62950 [details]
accidentally uploaded

We can use #if defined(XP_MACOSX) instead of #if XP_MACOSX ,
because XP_MACOSX is 1 when it is defined.
Comment 2 Csaba Osztrogonác 2010-07-29 08:51:10 PDT 
Created attachment 62951 [details]
proposed patch

We can use #if defined(XP_MACOSX) instead of #if XP_MACOSX ,
because XP_MACOSX is 1 when it is defined.
Comment 3 Antonio Gomes 2010-07-29 08:55:47 PDT 
Comment on attachment 62951 [details]
proposed patch

r=me , can you wait green builtbots before commit, please?
Comment 4 Csaba Osztrogonác 2010-07-29 09:14:03 PDT 
Comment on attachment 62951 [details]
proposed patch

Clearing flags on attachment: 62951

Committed r64282: <http://trac.webkit.org/changeset/64282>
Comment 5 Csaba Osztrogonác 2010-07-29 09:14:11 PDT 
All reviewed patches have been landed.  Closing bug.