Bug 43190 - Rename all the IDBIndex classses to match the latest conventions
Summary: Rename all the IDBIndex classses to match the latest conventions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Jeremy Orlow
URL:
Keywords:
Depends on:
Blocks: 42969
  Show dependency tree / graph
 
Reported: 2010-07-29 07:39 PDT by Jeremy Orlow
Modified: 2010-08-04 06:28 PDT (History)
3 users (show)

See Also:

Attachments
Patch (61.74 KB, patch)
2010-07-29 07:48 PDT, Jeremy Orlow 		steveblock: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2010-07-29 07:39:11 PDT 
Rename all the IDBIndex classses to match the latest conventions
Comment 1 Jeremy Orlow 2010-07-29 07:48:54 PDT 
Created attachment 62945 [details]
Patch
Comment 2 Jeremy Orlow 2010-07-29 07:49:59 PDT 
The diff didn't handle the IDBIndex.h -> IDBIndexBackendInterface.h and IDBIndexRequest.h -> IDBIndex.h change gracefully.

Otherwise ready for review.
Comment 3 Steve Block 2010-07-29 08:10:50 PDT 
Comment on attachment 62945 [details]
Patch

WebCore/ChangeLog:13
 +          up the naming in general to make things more clear.  In the future, we're
It would be good if you could list the before and after name for each class. Or even split this change into two - a renaming due to the spec change, plus a clean-up.
Comment 4 Jeremy Orlow 2010-07-29 08:13:50 PDT 
There's almost no cleanup in this patch.  And the little there is should be quite obviously correct.   (Stuff like a variable being "Index" instead of "index".)

IDBIndex -> IDBIndexBackendInterface
IDBImpl -> IDBIndexBackendImpl
IDBIndexRequest -> IDBIndex
Comment 5 Jeremy Orlow 2010-07-29 08:14:07 PDT 
Er...IDBIndexImpl -> IDBIndexBackendImpl
Comment 6 Steve Block 2010-07-29 09:08:03 PDT 
Comment on attachment 62945 [details]
Patch

WebCore/CMakeLists.txt:1440
 +      storage/IDBIndexBackendImpl.cpp
Were these missing before?
Comment 7 Jeremy Orlow 2010-07-29 09:13:24 PDT 
(In reply to comment #6)
> (From update of attachment 62945 [details])
> WebCore/CMakeLists.txt:1440
>  +      storage/IDBIndexBackendImpl.cpp
> Were these missing before?

Yup.
Comment 8 Jeremy Orlow 2010-07-30 08:30:20 PDT 
Committed r64358: <http://trac.webkit.org/changeset/64358>