Bug 43183 - Web Inspector: Crash on refresh with a comment selected in the Elements panel
Summary: Web Inspector: Crash on refresh with a comment selected in the Elements panel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-29 02:24 PDT by Alexander Pavlov (apavlov)
Modified: 2010-07-30 01:44 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Suggested solution (1.95 KB, patch)
2010-07-29 03:01 PDT, Alexander Pavlov (apavlov)
no flags Details | Formatted Diff | Diff
[PATCH] A more bulletproof fix. Returns 0 instead of the document element if the node path is empty (1.92 KB, patch)
2010-07-29 03:11 PDT, Alexander Pavlov (apavlov)
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2010-07-29 02:24:03 PDT
1) Open the following HTML file:
<!-- 111 -->
2) Bring up the WebInspector and select the comment "111" in the Elements panel.
3) Refresh the inspected page by hitting Ctrl-R in the inspector a couple times.

A crash occurs.
Comment 1 Alexander Pavlov (apavlov) 2010-07-29 03:01:22 PDT
Created attachment 62932 [details]
[PATCH] Suggested solution
Comment 2 Alexander Pavlov (apavlov) 2010-07-29 03:01:49 PDT
Upstreamed issue http://code.google.com/p/chromium/issues/detail?id=50207
Comment 3 Alexander Pavlov (apavlov) 2010-07-29 03:11:04 PDT
Created attachment 62933 [details]
[PATCH] A more bulletproof fix. Returns 0 instead of the document element if the node path is empty
Comment 4 Alexander Pavlov (apavlov) 2010-07-29 03:11:48 PDT
Also http://code.google.com/p/chromium/issues/detail?id=49550 in Chromium bugs
Comment 5 Alexander Pavlov (apavlov) 2010-07-30 01:44:54 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebCore/ChangeLog
        M       WebCore/inspector/InspectorDOMAgent.cpp
        M       WebCore/inspector/front-end/ElementsPanel.js
Committed r64341