Bug 43176 - [WML] Add dummy argument to SelectElement::defaultEventHandler() in WMLSelectElement
Summary: [WML] Add dummy argument to SelectElement::defaultEventHandler() in WMLSelect...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-29 00:31 PDT by Gyuyoung Kim
Modified: 2010-08-07 20:01 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.23 KB, patch)
2010-07-29 00:33 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
patch (1.23 KB, patch)
2010-07-29 00:43 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2010-07-29 00:31:43 PDT 
An parameter was added to defaultEventHandler() of SelectElement. So, WMLSelectElement should use the defaultEventHandler with 4 parameters. However, the new parameter is HTMLFormElement. It is difficult to set the HTMLFormElement in WMLSelectElement.cpp.
For now, I add NULL instead of the HTMLFormElement in order to prevent build break when wml is enabled. IMO, this issue should be fixed later.
Comment 1 Gyuyoung Kim 2010-07-29 00:33:52 PDT 
Created attachment 62924 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-29 00:35:09 PDT 
Attachment 62924 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/wml/WMLSelectElement.cpp:170:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gyuyoung Kim 2010-07-29 00:43:05 PDT 
Created attachment 62925 [details]
patch

I change NULL with 0.
Comment 4 Eric Seidel (no email) 2010-08-07 20:01:03 PDT 
Comment on attachment 62925 [details]
patch

Clearing flags on attachment: 62925

Committed r64931: <http://trac.webkit.org/changeset/64931>
Comment 5 Eric Seidel (no email) 2010-08-07 20:01:08 PDT 
All reviewed patches have been landed.  Closing bug.