RESOLVED FIXED 43176
[WML] Add dummy argument to SelectElement::defaultEventHandler() in WMLSelectElement 
https://bugs.webkit.org/show_bug.cgi?id=43176
Summary [WML] Add dummy argument to SelectElement::defaultEventHandler() in WMLSelect...
Gyuyoung Kim
Reported Thursday, July 29, 2010 8:31:43 AM UTC
An parameter was added to defaultEventHandler() of SelectElement. So, WMLSelectElement should use the defaultEventHandler with 4 parameters. However, the new parameter is HTMLFormElement. It is difficult to set the HTMLFormElement in WMLSelectElement.cpp. For now, I add NULL instead of the HTMLFormElement in order to prevent build break when wml is enabled. IMO, this issue should be fixed later.
Attachments
Patch (1.23 KB, patch)
2010-07-29 00:33 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
patch (1.23 KB, patch)
2010-07-29 00:43 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 Thursday, July 29, 2010 8:33:52 AM UTC
Created attachment 62924 [details] Patch
WebKit Review Bot
Comment 2 Thursday, July 29, 2010 8:35:09 AM UTC
Attachment 62924 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/wml/WMLSelectElement.cpp:170: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gyuyoung Kim
Comment 3 Thursday, July 29, 2010 8:43:05 AM UTC
Created attachment 62925 [details] patch I change NULL with 0.
Eric Seidel (no email)
Comment 4 Sunday, August 8, 2010 4:01:03 AM UTC
Comment on attachment 62925 [details] patch Clearing flags on attachment: 62925 Committed r64931: <http://trac.webkit.org/changeset/64931>
Eric Seidel (no email)
Comment 5 Sunday, August 8, 2010 4:01:08 AM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.