Bug 43173 - [WML] Add KURL parameter to WMLDocument::create()
Summary: [WML] Add KURL parameter to WMLDocument::create()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-28 23:16 PDT by Gyuyoung Kim
Modified: 2019-05-02 16:22 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.88 KB, patch)
2010-07-28 23:20 PDT, Gyuyoung Kim 		eric: review-
Details | Formatted Diff | Diff
Patch (1.99 KB, patch)
2010-08-06 19:22 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (1.99 KB, patch)
2010-08-06 20:10 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2010-07-28 23:16:42 PDT 
An url parameter was added to Document class. So. WMLDocument should support url parameter as well.
Comment 1 Gyuyoung Kim 2010-07-28 23:20:31 PDT 
Created attachment 62919 [details]
Patch

Patch.
Comment 2 Gyuyoung Kim 2010-08-05 18:31:36 PDT 
Hello Eric,

Could you please review this patch?
Comment 3 Eric Seidel (no email) 2010-08-06 10:45:15 PDT 
Comment on attachment 62919 [details]
Patch

Why?  Neither your bug or your ChangeLog say why?

Is this a build fix?
Comment 4 Gyuyoung Kim 2010-08-06 19:22:40 PDT 
Created attachment 63795 [details]
Patch

(In reply to comment #3)
> (From update of attachment 62919 [details])
> Why?  Neither your bug or your ChangeLog say why?
> 
> Is this a build fix?

Yes, right.  This patch is to fix build break.

WMLDocument inherits Document class as below,

    WMLDocument::WMLDocument(Frame* frame)
       : Document(frame, false, false)

However, the Document Class's construct parameters were changed. url was added.

    Document::Document(Frame* frame, const KURL& url, bool isXHTML, bool isHTML)

So. I make this patch to fix build break when wml is enabled.

I add comment to Changelog.
Comment 5 Gyuyoung Kim 2010-08-06 20:10:33 PDT 
Created attachment 63798 [details]
Patch

Previous patch has something wrong. I upload this patch again.

Thank you.
Comment 6 Eric Seidel (no email) 2010-08-06 20:10:43 PDT 
Comment on attachment 63795 [details]
Patch

Looks fine. Looks like it does not apply though.
Comment 7 Eric Seidel (no email) 2010-08-07 23:45:42 PDT 
Comment on attachment 63798 [details]
Patch

Clearing flags on attachment: 63798

Committed r64941: <http://trac.webkit.org/changeset/64941>
Comment 8 Eric Seidel (no email) 2010-08-07 23:45:48 PDT 
All reviewed patches have been landed.  Closing bug.