Bug 43162 - Add support for MADV_FREE to PageAllocation
Summary: Add support for MADV_FREE to PageAllocation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-28 17:24 PDT by Gavin Barraclough
Modified: 2010-07-28 20:22 PDT (History)
1 user (show)

See Also:

Attachments
The patch (1.38 KB, patch)
2010-07-28 17:27 PDT, Gavin Barraclough 		no flags Details | Formatted Diff | Diff
Errk, better patch (1.95 KB, patch)
2010-07-28 17:29 PDT, Gavin Barraclough 		darin: review-
Details | Formatted Diff | Diff
Even better patch! (2.28 KB, patch)
2010-07-28 18:13 PDT, Gavin Barraclough 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2010-07-28 17:24:22 PDT 
This is useful on platforms that don't have MADV_FREE_REUS(ABL)E.
Comment 1 Gavin Barraclough 2010-07-28 17:27:52 PDT 
Created attachment 62897 [details]
The patch
Comment 2 Gavin Barraclough 2010-07-28 17:29:53 PDT 
Created attachment 62898 [details]
Errk, better patch
Comment 3 Early Warning System Bot 2010-07-28 17:32:50 PDT 
Attachment 62897 [details] did not build on qt:
Build output: http://queues.webkit.org/results/3596522
Comment 4 Darin Adler 2010-07-28 17:36:02 PDT 
Comment on attachment 62898 [details]
Errk, better patch

I think this would be more readable if the #ifs were moved exclusively inside the commit and decommit functions.

This won't compile because you've left the argument names out even though you are using them in decommit.
Comment 5 Gavin Barraclough 2010-07-28 18:13:13 PDT 
Created attachment 62908 [details]
Even better patch!
Comment 6 Gavin Barraclough 2010-07-28 20:22:54 PDT 
Transmitting file data ..
Committed revision 64261.