RESOLVED FIXED 43155
Implement NPN_HasMethod 
https://bugs.webkit.org/show_bug.cgi?id=43155
Summary Implement NPN_HasMethod
Anders Carlsson
Reported 2010-07-28 15:44:50 PDT
Implement NPN_HasMethod
Attachments
Patch (8.12 KB, patch)
2010-07-28 15:47 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-07-28 15:47:31 PDT
Created attachment 62889 [details] Patch
WebKit Review Bot
Comment 2 2010-07-28 15:48:14 PDT
Attachment 62889 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:574: NPN_HasProperty is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:582: NPN_HasMethod is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.cpp:181: NPJSObject::NP_HasMethod is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.cpp:186: NPJSObject::NP_Invoke is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.cpp:192: NPJSObject::NP_InvokeDefault is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.cpp:208: NPJSObject::NP_SetProperty is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.h:69: NP_HasMethod is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.h:70: NP_Invoke is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.h:71: NP_InvokeDefault is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.h:72: NP_HasProperty is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.h:73: NP_GetProperty is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.h:74: NP_SetProperty is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 12 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2010-07-28 16:03:40 PDT
Committed r64240: <http://trac.webkit.org/changeset/64240>
Anders Carlsson
Comment 4 2010-07-28 16:35:03 PDT
Committed r64240: <http://trac.webkit.org/changeset/64240>
Note You need to log in before you can comment on or make changes to this bug.