Bug 43145 - Add support for calling NPObject methods
Summary: Add support for calling NPObject methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-28 13:44 PDT by Anders Carlsson
Modified: 2010-07-28 14:31 PDT (History)
0 users

See Also:


Attachments
Patch (30.71 KB, patch)
2010-07-28 13:57 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-07-28 13:44:49 PDT
Add support for calling NPObject methods
Comment 1 Anders Carlsson 2010-07-28 13:57:47 PDT
Created attachment 62873 [details]
Patch
Comment 2 Sam Weinig 2010-07-28 14:04:10 PDT
Comment on attachment 62873 [details]
Patch

> +    if (!returnValue)
> +        throwError(exec, createError(exec, "Error calling method on NPObject!"));

Do we need the exclamation point?

Otherwise, r=me.
Comment 3 Anders Carlsson 2010-07-28 14:31:17 PDT
Committed r64231: <http://trac.webkit.org/changeset/64231>