Bug 43141 - Minor compile errors in loadMediaPlayerProxyPlugin
Summary: Minor compile errors in loadMediaPlayerProxyPlugin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-28 13:15 PDT by Bryan Gislason
Modified: 2010-07-28 20:25 PDT (History)
2 users (show)

See Also:

Attachments
3 small fixes (1.85 KB, patch)
2010-07-28 13:15 PDT, Bryan Gislason 		japhet: review-
Details | Formatted Diff | Diff
add a changelog (1.87 KB, patch)
2010-07-28 15:17 PDT, Bryan Gislason 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bryan Gislason 2010-07-28 13:15:45 PDT 
Created attachment 62870 [details]
3 small fixes

These were not caught in initial compile because PLUGIN_PROXY_PROXY_FOR_VIDEO was not enabled.
Comment 1 Nate Chapin 2010-07-28 13:27:37 PDT 
Comment on attachment 62870 [details]
3 small fixes

Code looks fine, but you need a ChangeLog.

WebKitTools/Scripts/prepare-changelog will give you a stub in WebCore/ChangeLog that you can fill out.
Comment 2 Bryan Gislason 2010-07-28 15:17:01 PDT 
Created attachment 62884 [details]
add a changelog
Comment 3 Nate Chapin 2010-07-28 15:23:12 PDT 
Comment on attachment 62884 [details]
add a changelog

Thanks!
Comment 4 WebKit Commit Bot 2010-07-28 20:25:03 PDT 
Comment on attachment 62884 [details]
add a changelog

Clearing flags on attachment: 62884

Committed r64262: <http://trac.webkit.org/changeset/64262>
Comment 5 WebKit Commit Bot 2010-07-28 20:25:07 PDT 
All reviewed patches have been landed.  Closing bug.