Bug 43120 – [IndexedDB] WebDOMStringList default ctor does not initialize its m_private member variable so any attempt to append strings to a WebDOMStringList instance results in a crash.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andrei Popescu]

[IndexedDB] WebDOMStringList default ctor does not initialize its m_private member variable so any attempt to append strings to a WebDOMStringList instance results in a crash.

[Andrei Popescu]

Created attachment 62824 [details]
Patch

[Jeremy Orlow]

Comment on attachment 62824 [details]
Patch

LayoutTests/storage/indexeddb/script-tests/objectstore-basics.js:37
 +      shouldBe("storeNames.contains('storeName')", "true");
Maybe also check that there's only this one item?

WebKit/chromium/public/WebDOMStringList.h:49
 +      WebDOMStringList();
I'd lean towards making this private and have 2 factory methods instead: "createEmpty" and "createNull".  Though since no one needs the "null" behavior today, I'm OK with you leaving this as is.

me

[Andrei Popescu]

(In reply to comment #2)
> (From update of attachment 62824 [details])
> LayoutTests/storage/indexeddb/script-tests/objectstore-basics.js:37
>  +      shouldBe("storeNames.contains('storeName')", "true");
> Maybe also check that there's only this one item?
> 

Checked.

> WebKit/chromium/public/WebDOMStringList.h:49
>  +      WebDOMStringList();
> I'd lean towards making this private and have 2 factory methods instead: "createEmpty" and "createNull".  Though since no one needs the "null" behavior today, I'm OK with you leaving this as is.
> 

Cool, thank you.

[Andrei Popescu]

Committed r64209: <http://trac.webkit.org/changeset/64209>