Bug 43107 – rebaseline masking-intro-01-f.svg - diffs are in the antialiasing

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Alex Nicolaou]

Linux diffs for svg/W3C-SVG-1.1/masking-intro-01-f.svg are only in the antialiasing between the light blues, so I will rebaseline this test.

[Alex Nicolaou]

Created attachment 62983 [details]
Patch

[Ojan Vafai]

Comment on attachment 62983 [details]
Patch

> -BUGWK42403 LINUX WIN : svg/W3C-SVG-1.1/masking-intro-01-f.svg = IMAGE
> +BUGWK42403 WIN : svg/W3C-SVG-1.1/masking-intro-01-f.svg = IMAGE MISSING

As discussed on #webkit, this should just be an IMAGE failure, but it sounds like you might just add new baselines for Windows in this patch as well (even better).

[Alex Nicolaou]

I spent a bit of time to track this down and the difference in the antialiasing is introduced by the fix in bug 42228 which adjusts the colorspace that is used for masking. That fix is definitely correct and that patch contains nothing else.

Further the rendering matches pretty well the rendering by firefox as well as the PNG version here http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObject/masking-intro-01-f.html

So overall, I feel pretty comfortable with the rebaseline supplied here for Windows and Linux. However, this does render differently on Mac (note that the colorspace used there for SVG isn't exactly right) and looks better in Batik as well. However I'm confident that the change that introduced this diff did the right thing.

[Alex Nicolaou]

Created attachment 63410 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 63410 [details]
Patch

Rejecting patch 63410 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 255
Parsed 6 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum
literal is only avaliable with the XS version at /Library/Perl/5.8.8/Compress/Zlib.pm line 9
BEGIN failed--compilation aborted at /Library/Perl/5.8.8/Compress/Zlib.pm line 9.
Compilation failed in require at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/VCSUtils.pm line 1662.

Full output: http://queues.webkit.org/results/3597846

[Eric Seidel (no email)]

This is a bug in the cq setup, re: git support in svn-apply.

[Eric Seidel (no email)]

Comment on attachment 63410 [details]
Patch

I've cpan'd up the cq.  We'll see if it works better now.

[WebKit Commit Bot]

Comment on attachment 63410 [details]
Patch

Rejecting patch 63410 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 255
Parsed 6 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum
literal is only avaliable with the XS version at /Library/Perl/5.8.8/Compress/Zlib.pm line 9
BEGIN failed--compilation aborted at /Library/Perl/5.8.8/Compress/Zlib.pm line 9.
Compilation failed in require at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/VCSUtils.pm line 1662.

Full output: http://queues.webkit.org/results/3619571

[Adam Barth]

Comment on attachment 63410 [details]
Patch

Clearing flags on attachment: 63410

Committed r64894: <http://trac.webkit.org/changeset/64894>

[Adam Barth]

All reviewed patches have been landed.  Closing bug.