Bug 43107 - rebaseline masking-intro-01-f.svg - diffs are in the antialiasing
Summary: rebaseline masking-intro-01-f.svg - diffs are in the antialiasing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 42403
  Show dependency treegraph
 
Reported: 2010-07-27 21:36 PDT by Alex Nicolaou
Modified: 2010-08-06 21:11 PDT (History)
6 users (show)

See Also:


Attachments
Patch (39.63 KB, patch)
2010-07-29 13:45 PDT, Alex Nicolaou
no flags Details | Formatted Diff | Diff
Patch (62.38 KB, patch)
2010-08-03 21:24 PDT, Alex Nicolaou
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Nicolaou 2010-07-27 21:36:43 PDT
Linux diffs for svg/W3C-SVG-1.1/masking-intro-01-f.svg are only in the antialiasing between the light blues, so I will rebaseline this test.
Comment 1 Alex Nicolaou 2010-07-29 13:45:05 PDT
Created attachment 62983 [details]
Patch
Comment 2 Ojan Vafai 2010-07-29 13:55:02 PDT
Comment on attachment 62983 [details]
Patch

> -BUGWK42403 LINUX WIN : svg/W3C-SVG-1.1/masking-intro-01-f.svg = IMAGE
> +BUGWK42403 WIN : svg/W3C-SVG-1.1/masking-intro-01-f.svg = IMAGE MISSING

As discussed on #webkit, this should just be an IMAGE failure, but it sounds like you might just add new baselines for Windows in this patch as well (even better).
Comment 3 Alex Nicolaou 2010-08-03 21:17:44 PDT
I spent a bit of time to track this down and the difference in the antialiasing is introduced by the fix in bug 42228 which adjusts the colorspace that is used for masking. That fix is definitely correct and that patch contains nothing else.

Further the rendering matches pretty well the rendering by firefox as well as the PNG version here http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObject/masking-intro-01-f.html

So overall, I feel pretty comfortable with the rebaseline supplied here for Windows and Linux. However, this does render differently on Mac (note that the colorspace used there for SVG isn't exactly right) and looks better in Batik as well. However I'm confident that the change that introduced this diff did the right thing.
Comment 4 Alex Nicolaou 2010-08-03 21:24:16 PDT
Created attachment 63410 [details]
Patch
Comment 5 WebKit Commit Bot 2010-08-05 05:38:34 PDT
Comment on attachment 63410 [details]
Patch

Rejecting patch 63410 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 255
Parsed 6 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum
literal is only avaliable with the XS version at /Library/Perl/5.8.8/Compress/Zlib.pm line 9
BEGIN failed--compilation aborted at /Library/Perl/5.8.8/Compress/Zlib.pm line 9.
Compilation failed in require at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/VCSUtils.pm line 1662.

Full output: http://queues.webkit.org/results/3597846
Comment 6 Eric Seidel (no email) 2010-08-05 10:53:36 PDT
This is a bug in the cq setup, re: git support in svn-apply.
Comment 7 Eric Seidel (no email) 2010-08-05 11:03:22 PDT
Comment on attachment 63410 [details]
Patch

I've cpan'd up the cq.  We'll see if it works better now.
Comment 8 WebKit Commit Bot 2010-08-05 11:53:35 PDT
Comment on attachment 63410 [details]
Patch

Rejecting patch 63410 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 255
Parsed 6 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum
literal is only avaliable with the XS version at /Library/Perl/5.8.8/Compress/Zlib.pm line 9
BEGIN failed--compilation aborted at /Library/Perl/5.8.8/Compress/Zlib.pm line 9.
Compilation failed in require at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/VCSUtils.pm line 1662.

Full output: http://queues.webkit.org/results/3619571
Comment 9 Adam Barth 2010-08-06 21:11:37 PDT
Comment on attachment 63410 [details]
Patch

Clearing flags on attachment: 63410

Committed r64894: <http://trac.webkit.org/changeset/64894>
Comment 10 Adam Barth 2010-08-06 21:11:45 PDT
All reviewed patches have been landed.  Closing bug.