43106 – can't see anything wrong with the output for circle-in-mask-with-shadow.svg

Bug 43106 - can't see anything wrong with the output for circle-in-mask-with-shadow.svg

Summary: can't see anything wrong with the output for circle-in-mask-with-shadow.svg

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	SVG (show other bugs)
Version:	528+ (Nightly build)
Hardware:	PC OS X 10.5

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:

Depends on:
Blocks:	42403
	Show dependency tree / graph

Reported:	2010-07-27 21:24 PDT by Alex Nicolaou
Modified:	2010-08-06 21:27 PDT (History)
CC List:	4 users (show)

See Also:

Attachments
Patch (80.29 KB, patch) 2010-08-03 19:47 PDT, Alex Nicolaou	no flags	Details \| Formatted Diff \| Diff
Patch (80.28 KB, patch) 2010-08-06 21:21 PDT, Alex Nicolaou	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alex Nicolaou 2010-07-27 21:24:20 PDT

circle-in-mask-with-shadow.svg looks like good output to me on my mac, though recent changes have perturbed it slightly. I am going to rebaseline.

Comment 1 Alex Nicolaou 2010-08-03 19:47:23 PDT

Created attachment 63405 [details]
Patch

Comment 2 WebKit Commit Bot 2010-08-05 05:14:30 PDT

Comment on attachment 63405 [details]
Patch

Rejecting patch 63405 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Dirk Schulze', u'--force']" exit_code: 255
Parsed 6 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.checksum
literal is only avaliable with the XS version at /Library/Perl/5.8.8/Compress/Zlib.pm line 9
BEGIN failed--compilation aborted at /Library/Perl/5.8.8/Compress/Zlib.pm line 9.
Compilation failed in require at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/VCSUtils.pm line 1662.

Full output: http://queues.webkit.org/results/3614598

Comment 3 Eric Seidel (no email) 2010-08-05 11:03:55 PDT

Comment on attachment 63405 [details]
Patch

I've cpan'd up the cq.  We'll see if it works better now.

Comment 4 WebKit Commit Bot 2010-08-05 11:35:07 PDT

Comment on attachment 63405 [details]
Patch

Rejecting patch 63405 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Dirk Schulze', u'--force']" exit_code: 255
Parsed 6 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.checksum
literal is only avaliable with the XS version at /Library/Perl/5.8.8/Compress/Zlib.pm line 9
BEGIN failed--compilation aborted at /Library/Perl/5.8.8/Compress/Zlib.pm line 9.
Compilation failed in require at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/VCSUtils.pm line 1662.

Full output: http://queues.webkit.org/results/3566938

Comment 5 Alex Nicolaou 2010-08-06 21:21:46 PDT

Created attachment 63803 [details]
Patch

Comment 6 Adam Barth 2010-08-06 21:27:47 PDT

Comment on attachment 63803 [details]
Patch

Clearing flags on attachment: 63803

Committed r64895: <http://trac.webkit.org/changeset/64895>

Comment 7 Adam Barth 2010-08-06 21:27:54 PDT

All reviewed patches have been landed.  Closing bug.