The code the enable to JIT checks every permutation of platform & OS individually, but now the JIT is enabled on the majority much all x86/x86-64/ARM/MIPS systems. It should be cleaner to just enable by default on these platforms, and explicitly disable on configs that don't aren't supported.
Also, rename ENABLE_JIT_OPTIMIZE_MOD to ENABLE_JIT_USE_SOFT_MODULO. I always find this confusing since enabling this "optimization" would be possible, but would be a regression on x86/x86-64 systems! I think it's clearer to reserve "JIT_OPTIMIZE" for compiler technologies applicable to all platforms, and make a more optional behaviour like this a "USE".
Created attachment 62764 [details]
Attachment 62764 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
Total errors found: 4 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
fixed in r64176.
There is a typo in ExecutableAllocator.h for MIPS. We need to use ! for the macro to test if GCC is < 4.4.3. Thanks!
--- ExecutableAllocator.h (revision 64473)
+++ ExecutableAllocator.h (working copy)
@@ -200,7 +200,7 @@
static void cacheFlush(void* code, size_t size)
#if COMPILER(GCC) && GCC_VERSION_AT_LEAST(4,3,0)
-#if WTF_MIPS_ISA_REV(2) && GCC_VERSION_AT_LEAST(4,4,3)
+#if WTF_MIPS_ISA_REV(2) && !GCC_VERSION_AT_LEAST(4,4,3)
asm("rdhwr %0, $1" : "=r" (lineSize));
Ooops, sorry Chao-ying, will fix this. Thanks! G.
Fix landed in r64619.