Bug 43088 - [GTK] Use GdkPixbuf for ImageBuffer::toDataURL
Summary: [GTK] Use GdkPixbuf for ImageBuffer::toDataURL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-27 15:42 PDT by Martin Robinson
Modified: 2010-08-03 05:32 PDT (History)
3 users (show)

See Also:

Attachments
Use GdkPixbuf for toDataURL (18.37 KB, patch)
2010-07-27 15:54 PDT, Martin Robinson 		xan.lopez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-07-27 15:42:01 PDT 
Currently, this method is implemented via Cairo, and so does not have access to the richer set of image types that GdkPixbuf supports. Unfortunately, GdkPixbuf cannot write GIF files, so that format will still be unsupported.
Comment 1 Martin Robinson 2010-07-27 15:54:58 PDT 
Created attachment 62763 [details]
Use GdkPixbuf for toDataURL
Comment 2 WebKit Review Bot 2010-07-27 15:57:05 PDT 
Attachment 62763 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/graphics/gtk/CairoUtilities.h:29:  cairo_surface_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/gtk/ImageBufferGtk.cpp:64:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/ImageBufferGtk.cpp:66:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Martin Robinson 2010-07-27 16:10:59 PDT 
The first error is a false positive, because I just add the cairo typedef to avoid the include. The second error I've filed a bug for here: https://bugs.webkit.org/show_bug.cgi?id=43090
Comment 4 Xan Lopez 2010-08-02 14:03:48 PDT 
Comment on attachment 62763 [details]
Use GdkPixbuf for toDataURL

The code in ImageBufferGtk should probably be LGPL, but other than that it looks OK.
Comment 5 Martin Robinson 2010-08-02 16:52:22 PDT 
Committed r64506: <http://trac.webkit.org/changeset/64506>
Comment 6 WebKit Review Bot 2010-08-02 17:31:53 PDT 
http://trac.webkit.org/changeset/64506 might have broken GTK Linux 64-bit Debug
The following changes are on the blame list:
http://trac.webkit.org/changeset/64506
http://trac.webkit.org/changeset/64507
Comment 7 Martin Robinson 2010-08-02 19:01:41 PDT 
Committed r64521: <http://trac.webkit.org/changeset/64521>