RESOLVED FIXED 43081
Unify blob related feature defines to ENABLE(BLOB) 
https://bugs.webkit.org/show_bug.cgi?id=43081
Summary Unify blob related feature defines to ENABLE(BLOB)
Jian Li
Reported 2010-07-27 14:56:41 PDT
We have quite a few feature defines for blob related features, like ENABLE(BLOB_SLICE) and ENABLE(FILE_READER). We do not want another feature define when we start to support blob URL. Thus it would be better if we could unify all blob related defines to one simple define. So we need to change ENABLE(BLOB_SLICE) and ENABLE(FILE_READER) to ENABLE(BLOB). The future work of blob URL is also going to put under ENABLE(BLOB). Note that ENABLE(FILE_WRITER) remains unchanged since it is also related to file system work and thus it needs additional guard.
Attachments
Proposed Patch (58.72 KB, patch)
2010-07-27 17:39 PDT, Jian Li 		levin: review-
jianli: commit-queue-
DetailsFormatted DiffDiff
Proposed Patch (58.79 KB, patch)
2010-07-27 18:00 PDT, Jian Li 		levin: review+
jianli: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2010-07-27 17:39:44 PDT
Created attachment 62779 [details] Proposed Patch
David Levin
Comment 2 2010-07-27 17:52:44 PDT
Comment on attachment 62779 [details] Proposed Patch r- due to removal of if's in BlobItem.* as discussed.
Jian Li
Comment 3 2010-07-27 18:00:34 PDT
Created attachment 62780 [details] Proposed Patch Fixed.
WebKit Review Bot
Comment 4 2010-08-05 11:06:13 PDT
http://trac.webkit.org/changeset/64763 might have broken Qt Linux Release
Jian Li
Comment 5 2010-08-05 11:30:09 PDT
Committed as http://trac.webkit.org/changeset/64763.
Note You need to log in before you can comment on or make changes to this bug.