Bug 43081 - Unify blob related feature defines to ENABLE(BLOB)
Summary: Unify blob related feature defines to ENABLE(BLOB)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jian Li
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-27 14:56 PDT by Jian Li
Modified: 2010-08-05 11:30 PDT (History)
6 users (show)

See Also:

Attachments
Proposed Patch (58.72 KB, patch)
2010-07-27 17:39 PDT, Jian Li 		levin: review-
jianli: commit-queue-
Details | Formatted Diff | Diff
Proposed Patch (58.79 KB, patch)
2010-07-27 18:00 PDT, Jian Li 		levin: review+
jianli: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2010-07-27 14:56:41 PDT 
We have quite a few feature defines for blob related features, like ENABLE(BLOB_SLICE) and ENABLE(FILE_READER). We do not want another feature define when we start to support blob URL. Thus it would be better if we could unify all blob related defines to one simple define. So we need to change ENABLE(BLOB_SLICE) and ENABLE(FILE_READER) to ENABLE(BLOB). The future work of blob URL is also going to put under ENABLE(BLOB). Note that ENABLE(FILE_WRITER) remains unchanged since it is also related to file system work and thus it needs additional guard.
Comment 1 Jian Li 2010-07-27 17:39:44 PDT 
Created attachment 62779 [details]
Proposed Patch
Comment 2 David Levin 2010-07-27 17:52:44 PDT 
Comment on attachment 62779 [details]
Proposed Patch

r- due to removal of if's in BlobItem.* as discussed.
Comment 3 Jian Li 2010-07-27 18:00:34 PDT 
Created attachment 62780 [details]
Proposed Patch

Fixed.
Comment 4 WebKit Review Bot 2010-08-05 11:06:13 PDT 
http://trac.webkit.org/changeset/64763 might have broken Qt Linux Release
Comment 5 Jian Li 2010-08-05 11:30:09 PDT 
Committed as http://trac.webkit.org/changeset/64763.