Bug 43076 - [Chromium] Add the ability to show right-aligned icons in the AutoFill popup.
Summary: [Chromium] Add the ability to show right-aligned icons in the AutoFill popup.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-27 13:53 PDT by James Hawkins
Modified: 2010-07-27 16:02 PDT (History)
3 users (show)

See Also:

Attachments
Patch (16.78 KB, patch)
2010-07-27 13:55 PDT, James Hawkins 		no flags Details | Formatted Diff | Diff
Patch (16.79 KB, patch)
2010-07-27 15:48 PDT, James Hawkins 		fishd: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Hawkins 2010-07-27 13:53:35 PDT 
[Chromium] Add the ability to show right-aligned icons in the AutoFill popup.
Comment 1 James Hawkins 2010-07-27 13:55:49 PDT 
Created attachment 62742 [details]
Patch
Comment 2 James Hawkins 2010-07-27 15:48:56 PDT 
Created attachment 62759 [details]
Patch
Comment 3 James Hawkins 2010-07-27 15:50:05 PDT 
Fixed a leak by using RefPtr to accept a PassRefPtr.
Comment 4 Darin Fisher (:fishd, Google) 2010-07-27 15:50:31 PDT 
Comment on attachment 62759 [details]
Patch

good catch on the memory leak.  r=me
Comment 5 David Holloway 2010-07-27 15:51:42 PDT 
LGTM.
Comment 6 James Hawkins 2010-07-27 16:02:13 PDT 
Committed r64173: <http://trac.webkit.org/changeset/64173>