WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
43068
Move NPJSObject out into separate files
https://bugs.webkit.org/show_bug.cgi?id=43068
Summary
Move NPJSObject out into separate files
Anders Carlsson
Reported
2010-07-27 12:22:26 PDT
Move NPJSObject out into separate files
Attachments
Patch
(19.96 KB, patch)
2010-07-27 12:25 PDT
,
Anders Carlsson
aroben
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2010-07-27 12:25:51 PDT
Created
attachment 62725
[details]
Patch
Adam Roben (:aroben)
Comment 2
2010-07-27 12:28:09 PDT
Comment on
attachment 62725
[details]
Patch r=me
WebKit Review Bot
Comment 3
2010-07-27 12:28:40 PDT
Attachment 62725
[details]
did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/Plugins/NPJSObject.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/WebProcess/Plugins/NPJSObject.cpp:129: NPJSObject::NP_Allocate is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.cpp:136: NPJSObject::NP_Deallocate is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.cpp:142: NPJSObject::NP_HasProperty is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.cpp:147: NPJSObject::NP_GetProperty is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPRuntimeObjectMap.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] WebKit2/WebProcess/Plugins/NPJSObject.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] WebKit2/WebProcess/Plugins/NPJSObject.h:66: NP_Allocate is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.h:67: NP_Deallocate is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.h:68: NP_HasProperty is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/NPJSObject.h:69: NP_GetProperty is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 11 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 4
2010-07-27 12:30:33 PDT
Committed
r64147
: <
http://trac.webkit.org/changeset/64147
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug