[chromium] cleanup temp files left by Linux DRT
Created attachment 62713 [details] Patch
There doesn't seem to be a way to tell the Chromium OS, so I used perl. Also, I'm not sure how to test this. Specifically, I'm not sure if I need to escape some parameters (when I run it from the command line, I need to escape the forward ticks and the $ in $OSNAME).
Oh, and for reference, these temp files are only left around by DRT processes that crash. Except right now, we have lots of crashing DRT processes.
(In reply to comment #2) > There doesn't seem to be a way to tell the Chromium OS, so I used perl. Do any of the properties in ConfigureBuild (like platform, fullPlatform, etc.) give you this information?
(In reply to comment #4) > (In reply to comment #2) > > There doesn't seem to be a way to tell the Chromium OS, so I used perl. > > Do any of the properties in ConfigureBuild (like platform, fullPlatform, etc.) give you this information? They don't currently since we name all of our machines "chromium". We could rename them to chromium-win, chromium-mac and chromium-linux. Perhaps that's a bit cleaner. I will upload a new patch with that.
Created attachment 62777 [details] Patch
Comment on attachment 62777 [details] Patch We need to update WebKitTools/BuildSlaveSupport/test-result-archive too though it doesn't work for chromium at this moment.
(In reply to comment #7) > (From update of attachment 62777 [details]) > We need to update WebKitTools/BuildSlaveSupport/test-result-archive too though it doesn't work for chromium at this moment. I'm not sure, but I think it'll be ok. The %(platform) property should be "chromium" (see the split on line 29 of master.cfg). build-product-archive doesn't seem to special case things like mac-tiger or mac-leopard. We might be able to use properties in some other places in master.cfg, but it's hard for me to tell which classes I can and which classes I can't use them.
Comment on attachment 62777 [details] Patch ok.
wms: Is there a way for me to run a test buildbot master+slave to test this change before landing it?
Yes, use the master.cfg from the svn repo and v0.7.12 of buildbot. You'll need to come up with a passwords file, but the master.cfg and config.json should make it obvious what to do with it.
Created attachment 62857 [details] Patch for landing
Created attachment 62858 [details] Patch for landing
Committed r64219: <http://trac.webkit.org/changeset/64219>
I was able to test on my machine and this should be working now. wms, can you schedule a master restart?
Graceful restart process has been begun.
(In reply to comment #16) > Graceful restart process has been begun. Did the restart happen? I was expecting to see a change to Chromium Linux Release (Tests) but I don't see it right now.
(In reply to comment #17) > (In reply to comment #16) > > Graceful restart process has been begun. > > Did the restart happen? I was expecting to see a change to Chromium Linux Release (Tests) but I don't see it right now. Ah, crap, the diff that was landed is missing a change. I probably screwed up a merge.
The restart hasn't happened yet. It is still waiting for all of the slaves to be idle.
(In reply to comment #19) > The restart hasn't happened yet. It is still waiting for all of the slaves to be idle. Ah, ok. Thanks for the update. It'll probably get a chance this weekend to restart. Turns out I was mistaken, the change includes everything that I tested.