Bug 43052 - [IndexedDB] Key range methods belong to the IDBKeyRange interface
Summary: [IndexedDB] Key range methods belong to the IDBKeyRange interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 41170 (view as bug list)
Depends on:
Blocks: 42966
  Show dependency tree / graph
 
Reported: 2010-07-27 08:43 PDT by Andrei Popescu
Modified: 2010-08-10 06:37 PDT (History)
4 users (show)

See Also:

Attachments
Patch (12.91 KB, patch)
2010-07-27 08:50 PDT, Andrei Popescu 		no flags Details | Formatted Diff | Diff
Patch (12.89 KB, patch)
2010-07-27 10:07 PDT, Andrei Popescu 		jorlow: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Popescu 2010-07-27 08:43:27 PDT 
[IndexedDB] Key range methods belong to the IDBKeyRange interface
Comment 1 Andrei Popescu 2010-07-27 08:50:48 PDT 
Created attachment 62697 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-27 09:10:09 PDT 
Attachment 62697 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/3621177
Comment 3 Andrei Popescu 2010-07-27 10:07:41 PDT 
Created attachment 62707 [details]
Patch
Comment 4 Jeremy Orlow 2010-07-27 10:34:42 PDT 
Comment on attachment 62707 [details]
Patch

WebCore/page/DOMWindow.cpp:487
 +      m_idb_key_range = 0;
not user hacker style

WebCore/page/DOMWindow.cpp:715
 +  
space isn't really necessary...but not super worried about it.

WebCore/page/DOMWindow.h:235
 +          IDBKeyRange* iDBKeyRange() const;
Does casing it like this even work?

r=me
Comment 5 Andrei Popescu 2010-07-27 11:04:46 PDT 
Committed r64141: <http://trac.webkit.org/changeset/64141>
Comment 6 Marcus Bulach 2010-08-10 06:37:55 PDT 
*** Bug 41170 has been marked as a duplicate of this bug. ***