Bug 43048 - UI process needs a way to find out when the web process crashes
Summary: UI process needs a way to find out when the web process crashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 43047
  Show dependency tree / graph
 
Reported: 2010-07-27 07:41 PDT by Adam Roben (:aroben)
Modified: 2010-07-27 09:08 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.75 KB, patch)
2010-07-27 08:32 PDT, Adam Roben (:aroben) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-07-27 07:41:19 PDT 
There's no API for the UI process to find out when the web process crashes. We should add one! Probably adding a WKPageProcessDidExitCallback member to WKPageLoaderClient is the way to go for now (though we might move it to wherever the DidBecome[Un]ResponsiveCallbacks go, once they move to a new client).
Comment 1 Adam Roben (:aroben) 2010-07-27 07:42:36 PDT 
<rdar://problem/8239458>
Comment 2 Adam Roben (:aroben) 2010-07-27 08:32:29 PDT 
Created attachment 62694 [details]
Patch
Comment 3 WebKit Review Bot 2010-07-27 08:33:20 PDT 
Attachment 62694 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKPage.h:96:  Extra space between WKPageProcessDidExitCallback and processDidExit  [whitespace/declaration] [3]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Adam Roben (:aroben) 2010-07-27 09:08:56 PDT 
Committed r64132: <http://trac.webkit.org/changeset/64132>