Bug 43035 - [Chromium] Make Chromium compile with ENABLE_DATABASE=0
Summary: [Chromium] Make Chromium compile with ENABLE_DATABASE=0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dumitru Daniliuc
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-27 03:03 PDT by Dumitru Daniliuc
Modified: 2010-07-27 18:09 PDT (History)
2 users (show)

See Also:

Attachments
patch (10.94 KB, patch)
2010-07-27 11:34 PDT, Dumitru Daniliuc 		dumi: commit-queue-
Details | Formatted Diff | Diff
patch (11.22 KB, patch)
2010-07-27 12:29 PDT, Dumitru Daniliuc 		levin: review+
dumi: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dumitru Daniliuc 2010-07-27 03:03:09 PDT 
We need to move all WebSQLDatabases code behind #if ENABLE(DATABASE) and make Chromium compile with ENABLE_DATABASE=0.
Comment 1 Dumitru Daniliuc 2010-07-27 11:34:01 PDT 
Created attachment 62717 [details]
patch
Comment 2 David Levin 2010-07-27 12:13:01 PDT 
I would be happy to r+ this except I can't figure out why various files have the ifdef's removed. (Beating a dead horse, some very short ChangeLog comments would be helpful in explaining this.)
Comment 3 Dumitru Daniliuc 2010-07-27 12:23:35 PDT 
(In reply to comment #2)
> I would be happy to r+ this except I can't figure out why various files have the ifdef's removed. (Beating a dead horse, some very short ChangeLog comments would be helpful in explaining this.)

there's a layer of "general" DB classes in WebCore/platform/sql/, and then a layer of HTML5 DB classes in WebCore/storage/. DatabaseAuthorizer.cpp and ChromiumBridge.{h|cpp} are used by the "general" DB classes, which are used by other features too (like Geolocation). so those functions need to be compiled in even when HTML5 DBs are turned off.

i'll add this to the ChangeLog comments and re-upload the patch in a second.
Comment 4 Dumitru Daniliuc 2010-07-27 12:29:16 PDT 
Created attachment 62726 [details]
patch
Comment 5 Dumitru Daniliuc 2010-07-27 18:08:50 PDT 
landed: r64151.
Comment 6 Dumitru Daniliuc 2010-07-27 18:09:13 PDT 
landed: r64151.