Bug 43019 - Plug-in views should be able to return JSObjects directly
Summary: Plug-in views should be able to return JSObjects directly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-26 17:02 PDT by Anders Carlsson
Modified: 2010-07-26 17:09 PDT (History)
1 user (show)

See Also:


Attachments
Patch (14.65 KB, patch)
2010-07-26 17:05 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-07-26 17:02:23 PDT
Plug-in views should be able to return JSObjects directly
Comment 1 Anders Carlsson 2010-07-26 17:05:53 PDT
Created attachment 62631 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-26 17:07:07 PDT
Attachment 62631 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/plugins/PluginViewBase.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2010-07-26 17:07:41 PDT
Comment on attachment 62631 [details]
Patch

Lovely. r=me
Comment 4 Anders Carlsson 2010-07-26 17:09:22 PDT
Committed r64093: <http://trac.webkit.org/changeset/64093>