Bug 43009 - Abstract out page allocation from executable allocators
Summary: Abstract out page allocation from executable allocators
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-26 15:18 PDT by Gavin Barraclough
Modified: 2010-07-27 00:31 PDT (History)
0 users

See Also:

Attachments
The patch (42.69 KB, patch)
2010-07-26 15:23 PDT, Gavin Barraclough 		barraclough: review-
Details | Formatted Diff | Diff
Tha's better! (45.72 KB, patch)
2010-07-26 17:42 PDT, Gavin Barraclough 		oliver: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2010-07-26 15:18:29 PDT 
It would be great to have a single platform abstraction for block allocation, rather than copy/paste code.
Comment 1 Gavin Barraclough 2010-07-26 15:23:36 PDT 
Created attachment 62619 [details]
The patch

No perf impact.
Comment 2 Gavin Barraclough 2010-07-26 15:25:01 PDT 
Comment on attachment 62619 [details]
The patch

Ooop! not fixed allocation @ address yet!
Comment 3 Gavin Barraclough 2010-07-26 17:42:30 PDT 
Created attachment 62632 [details]
Tha's better!
Comment 4 Oliver Hunt 2010-07-26 17:50:35 PDT 
Comment on attachment 62632 [details]
Tha's better!

r=me
Comment 5 Gavin Barraclough 2010-07-27 00:31:23 PDT 
Fixed in r64105-64108