Bug 43004 – WebElement should provide access to attributes

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Dominic Mazzoni]

For Windows accessibility, we need direct access to some of the attributes of a WebElement.

[Dominic Mazzoni]

Created attachment 62616 [details]
Implements proposed feature

[WebKit Review Bot]

Attachment 62616 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/src/WebAttribute.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/chromium/src/WebElement.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[chris fleizach]

Comment on attachment 62616 [details]
Implements proposed feature

is there any chance of getting a layout test with this?

[Dominic Mazzoni]

This is all chromium wrapper code, and I have a chromium browser test ready for review that exercises these new APIs and makes sure they work. I'll send a link to the code review when I upload it.

I'm also happy to add a layout test as well, but is there any infrastructure now to access chromium wrappers like WebNode, WebElement from a layout test? As far as I can tell, building WebKit by itself doesn't even compile the code in the chromium/ directory...but if I'm missing something, please point me in the right direction!

- Dominic

[chris fleizach]

(In reply to comment #4)
> This is all chromium wrapper code, and I have a chromium browser test ready for review that exercises these new APIs and makes sure they work. I'll send a link to the code review when I upload it.
> 
> I'm also happy to add a layout test as well, but is there any infrastructure now to access chromium wrappers like WebNode, WebElement from a layout test? As far as I can tell, building WebKit by itself doesn't even compile the code in the chromium/ directory...but if I'm missing something, please point me in the right direction!
> 
> - Dominic

I don't know anything about how chromium builds accessibility, but I imagine DumpRenderTree could be modified to accommodate testing these things. I think it would be useful to figure out how to write layout tests for changes like these

[chris fleizach]

Comment on attachment 62616 [details]
Implements proposed feature

r=me

[WebKit Commit Bot]

Comment on attachment 62616 [details]
Implements proposed feature

Clearing flags on attachment: 62616

Committed r64112: <http://trac.webkit.org/changeset/64112>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.