Bug 42995 - Add ability for WK2 to register a scheme to always be displayed as an empty document
Summary: Add ability for WK2 to register a scheme to always be displayed as an empty d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-26 13:25 PDT by Brady Eidson
Modified: 2010-07-26 13:38 PDT (History)
1 user (show)

See Also:


Attachments
Patch (9.56 KB, patch)
2010-07-26 13:26 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (9.69 KB, patch)
2010-07-26 13:28 PDT, Brady Eidson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2010-07-26 13:25:10 PDT
Add ability for WK2 to register a scheme to always be displayed as an empty document
Comment 1 Brady Eidson 2010-07-26 13:26:49 PDT
Created attachment 62597 [details]
Patch
Comment 2 Brady Eidson 2010-07-26 13:28:02 PDT
Created attachment 62598 [details]
Patch
Comment 3 WebKit Review Bot 2010-07-26 13:28:25 PDT
Attachment 62597 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKContext.cpp:102:  _WKContextRegisterURLSchemeAsEmptyDocument is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Review Bot 2010-07-26 13:28:53 PDT
Attachment 62598 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKContext.cpp:102:  _WKContextRegisterURLSchemeAsEmptyDocument is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Brady Eidson 2010-07-26 13:38:11 PDT
Committed r64070: <http://trac.webkit.org/changeset/64070>