Bug 42988 - Deliver mouse and wheel events to plug-ins
Summary: Deliver mouse and wheel events to plug-ins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-26 11:53 PDT by Anders Carlsson
Modified: 2010-07-26 14:15 PDT (History)
3 users (show)

See Also:


Attachments
Patch (32.48 KB, patch)
2010-07-26 11:58 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-07-26 11:53:46 PDT
Deliver mouse and wheel events to plug-ins
Comment 1 Anders Carlsson 2010-07-26 11:58:31 PDT
Created attachment 62592 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-26 12:00:48 PDT
Attachment 62592 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/WebPage/WebPage.cpp:280:  g_currentEvent is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:79:  NPP_HandleEvent is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:208:  NetscapePlugin::NPP_HandleEvent is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 3 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2010-07-26 12:42:16 PDT
Committed r64063: <http://trac.webkit.org/changeset/64063>
Comment 4 Daniel Bates 2010-07-26 14:13:54 PDT
(In reply to comment #3)
> Committed r64063: <http://trac.webkit.org/changeset/64063>

This change caused linker errors on the Apple Windows build bots.

See <http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/20153/steps/compile-webkit/logs/stdio>.