$ ./WebKitTools/Scripts/webkit-patch post-commits -m "Patch v1" HEAD
Traceback (most recent call last):
File "./WebKitTools/Scripts/webkit-patch", line 64, in <module>
File "./WebKitTools/Scripts/webkit-patch", line 59, in main
File "/Volumes/Data/WebKit.git/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main
result = command.check_arguments_and_execute(options, args, self)
File "/Volumes/Data/WebKit.git/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute
return self.execute(options, args, tool) or 0
File "/Volumes/Data/WebKit.git/WebKitTools/Scripts/webkitpy/tool/commands/upload.py", line 288, in execute
File "/Volumes/Data/WebKit.git/WebKitTools/Scripts/webkitpy/tool/steps/abstractstep.py", line 38, in __init__
AttributeError: Values instance has no attribute 'no_squash'
Note that "upload" keeps opening an editor for a patch that already has a ChangeLog, which is not what I want either:
./WebKitTools/Scripts/webkit-patch upload -m "Patch v1" -g HEAD
Looks like this needs a test case. :) Ojan is our master of --no-squash...
Created attachment 62731 [details]
Comment on attachment 62731 [details]
How does this change PostCommits?
This issue was that post-commits used an object that inherited from AbstractStep, which would check the values of these options without using the options in the AbstractStep itself. I think there's an architectural issue in the code here, but I'm not sure it's worth fixing now.
Committed r64153: <http://trac.webkit.org/changeset/64153>