Bug 42970 – [IndexedDB] IndexedDB is missing the Transaction interface.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Andrei Popescu]

We need to implement Transaction:

http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#transaction

This interface has changed significantly due to 

http://www.w3.org/Bugs/Public/show_bug.cgi?id=9975

So we need to update the IndexedDB implementation to match the current spec first. Hence this bug depends on 42966.

[Andrei Popescu]

Created attachment 63579 [details]
Patch

[WebKit Review Bot]

Attachment 63579 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/storage/IDBTransaction.idl:1:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 57 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jeremy Orlow]

Comment on attachment 63579 [details]
Patch

WebCore/dom/EventNames.h:45
 +      macro(complete) \
what is this stuff?

WebCore/storage/IDBDatabase.idl:42
 +          [CallWith=ScriptExecutionContext] IDBTransaction transaction (in [Optional] DOMStringList storeNames, in [Optional] unsigned short mode, in [Optional] unsigned long timeout);
not sure using domStringList as an input like this will work out of the box....I don't think anyone's tried

WebCore/storage/IDBTask.h:2
 +   * Copyright (C) 2010 Google Inc. All rights reserved.
use ScriptExecutionContext::Task and the CrossThreadTask stuff instead of rolling your own

WebCore/storage/IDBTransaction.cpp:15
 +      : ActiveDOMObject(context, this), m_transaction(backend), m_database(db)
put each on its own line

WebCore/storage/IDBTransaction.cpp:25
 +      return IDBTransaction::READ_ONLY;
Hook these up to the backend interface...I actually don't think you need any FIXMEs in this file since all the work happens in the backend.

WebCore/storage/IDBTransaction.h:85
 +      RefPtr<IDBTransactionBackendInterface> m_transaction;
m_backend maybe?

[Andrei Popescu]

Created attachment 63600 [details]
Patch

[Andrei Popescu]

Thanks for the quick review Jeremy!

(In reply to comment #3)
> (From update of attachment 63579 [details])
> WebCore/dom/EventNames.h:45
>  +      macro(complete) \
> what is this stuff?
>

IDBTransaction adds two new events: oncomplete and ontimeout.
 
> WebCore/storage/IDBDatabase.idl:42
>  +          [CallWith=ScriptExecutionContext] IDBTransaction transaction (in [Optional] DOMStringList storeNames, in [Optional] unsigned short mode, in [Optional] unsigned long timeout);
> not sure using domStringList as an input like this will work out of the box....I don't think anyone's tried
> 


Yeah, I'll check and see. If it's not working, I'll fix it in a separate patch.


> WebCore/storage/IDBTask.h:2
>  +   * Copyright (C) 2010 Google Inc. All rights reserved.
> use ScriptExecutionContext::Task and the CrossThreadTask stuff instead of rolling your own
> 

Used.

> WebCore/storage/IDBTransaction.cpp:15
>  +      : ActiveDOMObject(context, this), m_transaction(backend), m_database(db)
> put each on its own line
>

Put.
 
> WebCore/storage/IDBTransaction.cpp:25
>  +      return IDBTransaction::READ_ONLY;
> Hook these up to the backend interface...I actually don't think you need any FIXMEs in this file since all the work happens in the backend.
>

Hooked.
 
> WebCore/storage/IDBTransaction.h:85
>  +      RefPtr<IDBTransactionBackendInterface> m_transaction;
> m_backend maybe?

Done.

[WebKit Review Bot]

Attachment 63600 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/storage/IDBTransaction.idl:1:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 57 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andrei Popescu]

Created attachment 63601 [details]
Patch

[WebKit Review Bot]

Attachment 63601 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/storage/IDBTransaction.idl:1:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 57 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andrei Popescu]

Created attachment 63604 [details]
Patch

[Jeremy Orlow]

Comment on attachment 63604 [details]
Patch

WebCore/Android.mk:758
 +  	storage/IDBTransaction.cpp \
Alpha order

WebCore/CMakeLists.txt:349
 +      storage/IDBTransaction.idl
You need to add the other files too

WebCore/GNUmakefile.am:2902
 +  	WebCore/storage/IDBTransactionBackendInterface
.h


WebCore/storage/IDBTransaction.cpp:28
 +      return IDBTransaction::READ_ONLY;
forward to backend


r=me

[Andrei Popescu]

Committed r64824: <http://trac.webkit.org/changeset/64824>

[WebKit Review Bot]

http://trac.webkit.org/changeset/64824 might have broken Qt Windows 32-bit Release