RESOLVED FIXED 42961
Web Inspector: make sure proxy objects are JSON-stringifiable. 
https://bugs.webkit.org/show_bug.cgi?id=42961
Summary Web Inspector: make sure proxy objects are JSON-stringifiable.
Pavel Feldman
Reported 2010-07-26 02:51:49 PDT
Patch to follow.
Attachments
[PATCH] Proposed fix. (1.31 KB, patch)
2010-07-26 02:55 PDT, Pavel Feldman 		hamaji: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2010-07-26 02:55:02 PDT
Created attachment 62551 [details] [PATCH] Proposed fix.
Shinichiro Hamaji
Comment 2 2010-07-26 04:13:58 PDT
Comment on attachment 62551 [details] [PATCH] Proposed fix. Looks good
Pavel Feldman
Comment 3 2010-07-26 04:21:59 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/InjectedScript.js Committed r64040
WebKit Review Bot
Comment 4 2010-07-26 04:28:11 PDT
http://trac.webkit.org/changeset/64040 might have broken Qt Linux Release minimal
Joseph Pecoraro
Comment 5 2010-07-26 09:45:07 PDT
Which value was breaking this such that !! fixed the problem?
Pavel Feldman
Comment 6 2010-07-26 14:29:14 PDT
(In reply to comment #5) > Which value was breaking this such that !! fixed the problem? I guess it was object with no own property names: type === "object" && object !== null && (Object.getOwnPropertyNames(object).length || object.__proto__)) || type === "function" evaluated to "object.__proto__" that was non-boolean. Then proto was serialized which was wrong thing to do...
Note You need to log in before you can comment on or make changes to this bug.