Bug 42960 – [GStreamer] media/invalid-media-url-crash.html fails

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Philippe Normand]

Because our webkitmediasrc element doesn't push an error on the GStreamer bus if a wrong url is loaded.

[Philippe Normand]

Created attachment 62549 [details]
proposed patch

[Martin Robinson]

Comment on attachment 62549 [details]
proposed patch


>  void StreamingClient::wasBlocked(ResourceHandle*)
>  {
> +    WebKitWebSrcPrivate* priv = m_src->priv;
> +    GST_ERROR_OBJECT(m_src, "Request was blocked");
> +    GST_ELEMENT_ERROR(m_src, RESOURCE, OPEN_READ, ("Access to \"%s\" was blocked", priv->uri), (0));
>  }

>  void StreamingClient::cannotShowURL(ResourceHandle*)
>  {
> +    WebKitWebSrcPrivate* priv = m_src->priv;

Just a minor nit, you can simply use m_src->priv->uri here instead of caching
the pointer locally. LGTM with those lines changed.

[Philippe Normand]

Thanks, landed in http://trac.webkit.org/changeset/65486