Bug 42935 - [MSVC] Ensure 4 byte alignment on ARM
Summary: [MSVC] Ensure 4 byte alignment on ARM
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-24 06:06 PDT by Patrick R. Gansterer
Modified: 2010-07-24 17:40 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.45 KB, patch)
2010-07-24 06:07 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-07-24 06:06:11 PDT 
see patch
Comment 1 Patrick R. Gansterer 2010-07-24 06:07:26 PDT 
Created attachment 62502 [details]
Patch
Comment 2 Darin Adler 2010-07-24 12:41:23 PDT 
Comment on attachment 62502 [details]
Patch

> +#if COMPILER(MSVC)
> +#pragma pack(push)
> +#pragma pack(4)
> +#endif // COMPILER(MSVC)

I think having a comment on an endif that is only 2 lines away from the #if is overkill!

> +#if COMPILER(MSVC)
> +#pragma pack(pop)
> +#endif // COMPILER(MSVC)

And even moreso here.
Comment 3 Patrick R. Gansterer 2010-07-24 12:45:45 PDT 
(In reply to comment #2)
> I think having a comment on an endif that is only 2 lines away from the #if is overkill!
I think too, but I only did the same like for the X86 part. ;-)
Comment 4 WebKit Commit Bot 2010-07-24 17:40:41 PDT 
Comment on attachment 62502 [details]
Patch

Clearing flags on attachment: 62502

Committed r64017: <http://trac.webkit.org/changeset/64017>
Comment 5 WebKit Commit Bot 2010-07-24 17:40:46 PDT 
All reviewed patches have been landed.  Closing bug.