WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
42933
Cleanup defines in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=42933
Summary
Cleanup defines in Platform.h
Patrick R. Gansterer
Reported
2010-07-24 05:43:44 PDT
see patch
Attachments
Patch
(1.73 KB, patch)
2010-07-24 05:45 PDT
,
Patrick R. Gansterer
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1
2010-07-24 05:45:55 PDT
Created
attachment 62500
[details]
Patch All defines are handeld by buildsystem now.
Darin Adler
Comment 2
2010-07-24 12:40:24 PDT
Comment on
attachment 62500
[details]
Patch
> -#if PLATFORM(WIN) > +#if PLATFORM(WIN) && !OS(WINCE)
Why does this matter? Is PLATFORM(WIN) ever true when OS(WINCE) is also true? I think this part of the change is wrong.
Patrick R. Gansterer
Comment 3
2010-07-24 12:44:03 PDT
Comment on
attachment 62500
[details]
Patch (In reply to
comment #2
)
> (From update of
attachment 62500
[details]
) > > -#if PLATFORM(WIN) > > +#if PLATFORM(WIN) && !OS(WINCE) > > Why does this matter? Is PLATFORM(WIN) ever true when OS(WINCE) is also true? I think this part of the change is wrong.
WinCE+GDI defines PLATFORM(WIN), so it is correct. Cleaning up the PLATFORM() checks for WinCE is IMHO an other task. (e.g. There a too many OS(WINCE) && !PLATFORM(QT))
Darin Adler
Comment 4
2010-07-24 12:46:26 PDT
Comment on
attachment 62500
[details]
Patch That use of PLATFORM(WIN) is going to create tons of problems!
WebKit Commit Bot
Comment 5
2010-07-24 17:09:07 PDT
Comment on
attachment 62500
[details]
Patch Clearing flags on attachment: 62500 Committed
r64016
: <
http://trac.webkit.org/changeset/64016
>
WebKit Commit Bot
Comment 6
2010-07-24 17:09:11 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug