Bug 42933 - Cleanup defines in Platform.h
Summary: Cleanup defines in Platform.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-24 05:43 PDT by Patrick R. Gansterer
Modified: 2010-07-24 17:09 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.73 KB, patch)
2010-07-24 05:45 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-07-24 05:43:44 PDT 
see patch
Comment 1 Patrick R. Gansterer 2010-07-24 05:45:55 PDT 
Created attachment 62500 [details]
Patch

All defines are handeld by buildsystem now.
Comment 2 Darin Adler 2010-07-24 12:40:24 PDT 
Comment on attachment 62500 [details]
Patch

> -#if PLATFORM(WIN)
> +#if PLATFORM(WIN) && !OS(WINCE)

Why does this matter? Is PLATFORM(WIN) ever true when OS(WINCE) is also true? I think this part of the change is wrong.
Comment 3 Patrick R. Gansterer 2010-07-24 12:44:03 PDT 
Comment on attachment 62500 [details]
Patch

(In reply to comment #2)
> (From update of attachment 62500 [details])
> > -#if PLATFORM(WIN)
> > +#if PLATFORM(WIN) && !OS(WINCE)
> 
> Why does this matter? Is PLATFORM(WIN) ever true when OS(WINCE) is also true? I think this part of the change is wrong.
WinCE+GDI defines PLATFORM(WIN), so it is correct.

Cleaning up the PLATFORM() checks for WinCE is IMHO an other task. (e.g. There a too many OS(WINCE) && !PLATFORM(QT))
Comment 4 Darin Adler 2010-07-24 12:46:26 PDT 
Comment on attachment 62500 [details]
Patch

That use of PLATFORM(WIN) is going to create tons of problems!
Comment 5 WebKit Commit Bot 2010-07-24 17:09:07 PDT 
Comment on attachment 62500 [details]
Patch

Clearing flags on attachment: 62500

Committed r64016: <http://trac.webkit.org/changeset/64016>
Comment 6 WebKit Commit Bot 2010-07-24 17:09:11 PDT 
All reviewed patches have been landed.  Closing bug.