RESOLVED FIXED Bug 42910
[Chromium] In PopupMenuChromium label and text can overlap 
https://bugs.webkit.org/show_bug.cgi?id=42910
Summary [Chromium] In PopupMenuChromium label and text can overlap
Jay Civelli
Reported 2010-07-23 14:24:01 PDT
When using the autofill feature in Chrome, the text and label in the popup can overlap if they are long.
Attachments
Initial patch (1.37 KB, patch)
2010-07-23 14:41 PDT, Jay Civelli 		jcivelli: review-
DetailsFormatted DiffDiff
Right patch this time (1.76 KB, patch)
2010-07-23 14:44 PDT, Jay Civelli 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jay Civelli
Comment 1 2010-07-23 14:41:42 PDT
Created attachment 62462 [details] Initial patch
Jay Civelli
Comment 2 2010-07-23 14:42:19 PDT
Comment on attachment 62462 [details] Initial patch Uploaded wrong patch
Jay Civelli
Comment 3 2010-07-23 14:44:49 PDT
Created attachment 62463 [details] Right patch this time
James Hawkins
Comment 4 2010-07-23 14:47:58 PDT
LGTM
David Holloway
Comment 5 2010-07-23 15:08:35 PDT
LGTM.
WebKit Commit Bot
Comment 6 2010-07-27 14:41:54 PDT
Comment on attachment 62463 [details] Right patch this time Rejecting patch 62463 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20722 test cases. animations/play-state.html -> failed Exiting early after 1 failures. 123 tests run. 18.11s total testing time 122 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://queues.webkit.org/results/3612277
James Hawkins
Comment 7 2010-07-27 14:56:14 PDT
Speaking on behalf of Jay, who I'm not sure is around: I'm pretty positive this CL is not causing the test failure.
WebKit Commit Bot
Comment 8 2010-07-28 08:19:39 PDT
Comment on attachment 62463 [details] Right patch this time Clearing flags on attachment: 62463 Committed r64205: <http://trac.webkit.org/changeset/64205>
WebKit Commit Bot
Comment 9 2010-07-28 08:19:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.