Bug 42910 - [Chromium] In PopupMenuChromium label and text can overlap
Summary: [Chromium] In PopupMenuChromium label and text can overlap
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-07-23 14:24 PDT by Jay Civelli
Modified: 2010-07-28 08:19 PDT (History)
4 users (show)

See Also:

Initial patch (1.37 KB, patch)
2010-07-23 14:41 PDT, Jay Civelli
jcivelli: review-
Details | Formatted Diff | Diff
Right patch this time (1.76 KB, patch)
2010-07-23 14:44 PDT, Jay Civelli
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Civelli 2010-07-23 14:24:01 PDT
When using the autofill feature in Chrome, the text and label in the popup can overlap if they are long.
Comment 1 Jay Civelli 2010-07-23 14:41:42 PDT
Created attachment 62462 [details]
Initial patch
Comment 2 Jay Civelli 2010-07-23 14:42:19 PDT
Comment on attachment 62462 [details]
Initial patch

Uploaded wrong patch
Comment 3 Jay Civelli 2010-07-23 14:44:49 PDT
Created attachment 62463 [details]
Right patch this time
Comment 4 James Hawkins 2010-07-23 14:47:58 PDT
Comment 5 David Holloway 2010-07-23 15:08:35 PDT
Comment 6 WebKit Commit Bot 2010-07-27 14:41:54 PDT
Comment on attachment 62463 [details]
Right patch this time

Rejecting patch 62463 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20722 test cases.
animations/play-state.html -> failed

Exiting early after 1 failures. 123 tests run.
18.11s total testing time

122 test cases (99%) succeeded
1 test case (<1%) had incorrect layout

Full output: http://queues.webkit.org/results/3612277
Comment 7 James Hawkins 2010-07-27 14:56:14 PDT
Speaking on behalf of Jay, who I'm not sure is around: I'm pretty positive this CL is not causing the test failure.
Comment 8 WebKit Commit Bot 2010-07-28 08:19:39 PDT
Comment on attachment 62463 [details]
Right patch this time

Clearing flags on attachment: 62463

Committed r64205: <http://trac.webkit.org/changeset/64205>
Comment 9 WebKit Commit Bot 2010-07-28 08:19:43 PDT
All reviewed patches have been landed.  Closing bug.