Bug 42899 - AX: need a layout test testing misspelled words in attributed strings
Summary: AX: need a layout test testing misspelled words in attributed strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-23 09:29 PDT by chris fleizach
Modified: 2010-07-24 15:36 PDT (History)
3 users (show)

See Also:


Attachments
patch (11.70 KB, patch)
2010-07-23 09:35 PDT, chris fleizach
no flags Details | Formatted Diff | Diff
patch (13.67 KB, patch)
2010-07-23 09:36 PDT, chris fleizach
ddkilzer: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2010-07-23 09:29:13 PDT
i'm going to change how misspelled words are calculated. i need a layout test that verifies the feature works as expected now
Comment 1 chris fleizach 2010-07-23 09:35:41 PDT
Created attachment 62433 [details]
patch
Comment 2 chris fleizach 2010-07-23 09:36:32 PDT
Created attachment 62434 [details]
patch

forgot a change log
Comment 3 chris fleizach 2010-07-23 15:26:49 PDT
review anyone?
Comment 4 David Kilzer (:ddkilzer) 2010-07-23 21:52:09 PDT
Comment on attachment 62434 [details]
patch

r=me
Comment 5 WebKit Commit Bot 2010-07-24 02:39:59 PDT
Comment on attachment 62434 [details]
patch

Rejecting patch 62434 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20716 test cases.
platform/mac/accessibility/misspelled-attributed-string.html -> failed

Exiting early after 1 failures. 17228 tests run.
316.16s total testing time

17227 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
26 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/3593416
Comment 6 chris fleizach 2010-07-24 15:36:49 PDT
http://trac.webkit.org/changeset/64014