Bug 42888 – [WINCE] Buildfix for GraphicsContext

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Patrick R. Gansterer]

see patch

[Patrick R. Gansterer]

Created attachment 62410 [details]
Patch

[Patrick R. Gansterer]

(From attachment 62410 [details])
> -    dstRect.move(shadowSize);
> +    dstRect.move(shadowSize.width(), shadowSize.height());
shadowSize is a FloatSize and dstRect is a IntRect

[Adam Roben (:aroben)]

Comment on attachment 62410 [details]
Patch

In the future, it would be helpful for you to use svn-create-patch rather than plain "svn diff" to create your patches. The former does a few things to make the patches slightly easier to read (like putting function names above each chunk).

> @@ -1268,7 +1268,7 @@
>      
>      IntRect dstRect = fillRect;
>      
> -    dstRect.move(shadowSize);
> +    dstRect.move(shadowSize.width(), shadowSize.height());

Is truncating to int really the right thing to do here?

r=me, but I'll wait for an answer before marking this cq+.

[Patrick R. Gansterer]

(In reply to comment #3)
> Is truncating to int really the right thing to do here?
dstRect.inflate(shadowBlur) also casts shadowBlur from float to int.

[Adam Roben (:aroben)]

(In reply to comment #4)
> (In reply to comment #3)
> > Is truncating to int really the right thing to do here?
> dstRect.inflate(shadowBlur) also casts shadowBlur from float to int.

OK, but that doesn't answer the question. Maybe we should be rounding from float to int in both cases instead of truncating?

[Patrick R. Gansterer]

Created attachment 62438 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 62438 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 62438 [details]
Patch

Clearing flags on attachment: 62438

Committed r63989: <http://trac.webkit.org/changeset/63989>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.