Bug 42883 - Chromium DevTools: migrate from utility context-based injected script dispatch to upstream schema.
Summary: Chromium DevTools: migrate from utility context-based injected script dispatc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-23 01:49 PDT by Pavel Feldman
Modified: 2010-07-23 05:58 PDT (History)
5 users (show)

See Also:


Attachments
[PATCH] Proposed change. (4.90 KB, patch)
2010-07-23 01:50 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff
[PATCH] Tests fixed. (7.78 KB, patch)
2010-07-23 04:50 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-07-23 01:49:02 PDT
Patch to follow.
Comment 1 Pavel Feldman 2010-07-23 01:50:25 PDT
Created attachment 62396 [details]
[PATCH] Proposed change.
Comment 2 Pavel Feldman 2010-07-23 04:50:35 PDT
Created attachment 62414 [details]
[PATCH] Tests fixed.
Comment 3 Yury Semikhatsky 2010-07-23 04:55:00 PDT
Comment on attachment 62414 [details]
[PATCH] Tests fixed.

WebCore/inspector/front-end/InjectedScriptAccess.js:40
 +      else {
You don't need "else" since you return from the "if" branch.

WebCore/bindings/v8/ScriptProfile.cpp:43
 +      v8::HandleScope scope;
This shouldn't be necessary, please check.
Comment 4 Early Warning System Bot 2010-07-23 04:55:23 PDT
Attachment 62414 [details] did not build on qt:
Build output: http://queues.webkit.org/results/3567387
Comment 5 Eric Seidel (no email) 2010-07-23 04:55:59 PDT
Attachment 62414 [details] did not build on mac:
Build output: http://queues.webkit.org/results/3580339
Comment 6 WebKit Review Bot 2010-07-23 05:16:31 PDT
http://trac.webkit.org/changeset/63963 might have broken Qt Linux Release minimal and Qt Linux ARMv5 Release
Comment 7 Pavel Feldman 2010-07-23 05:58:45 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
    M    WebCore/ChangeLog
    M    WebCore/bindings/v8/ScriptProfile.cpp
    M    WebCore/inspector/InspectorController.cpp
    M    WebCore/inspector/front-end/InjectedScriptAccess.js
    M    WebKit/chromium/ChangeLog
    M    WebKit/chromium/src/ToolsAgent.h
    M    WebKit/chromium/src/WebDevToolsAgentImpl.cpp
    M    WebKit/chromium/src/WebDevToolsAgentImpl.h
    M    WebKit/chromium/src/js/DevToolsHostStub.js
    M    WebKit/chromium/src/js/InspectorControllerImpl.js
Committed r63965