Bug 42883 – Chromium DevTools: migrate from utility context-based injected script dispatch to upstream schema.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Patch to follow.

[Pavel Feldman]

Created attachment 62396 [details]
[PATCH] Proposed change.

[Pavel Feldman]

Created attachment 62414 [details]
[PATCH] Tests fixed.

[Yury Semikhatsky]

Comment on attachment 62414 [details]
[PATCH] Tests fixed.

WebCore/inspector/front-end/InjectedScriptAccess.js:40
 +      else {
You don't need "else" since you return from the "if" branch.

WebCore/bindings/v8/ScriptProfile.cpp:43
 +      v8::HandleScope scope;
This shouldn't be necessary, please check.

[Early Warning System Bot]

Attachment 62414 [details] did not build on qt:
Build output: http://queues.webkit.org/results/3567387

[Eric Seidel (no email)]

Attachment 62414 [details] did not build on mac:
Build output: http://queues.webkit.org/results/3580339

[WebKit Review Bot]

http://trac.webkit.org/changeset/63963 might have broken Qt Linux Release minimal and Qt Linux ARMv5 Release

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
    M    WebCore/ChangeLog
    M    WebCore/bindings/v8/ScriptProfile.cpp
    M    WebCore/inspector/InspectorController.cpp
    M    WebCore/inspector/front-end/InjectedScriptAccess.js
    M    WebKit/chromium/ChangeLog
    M    WebKit/chromium/src/ToolsAgent.h
    M    WebKit/chromium/src/WebDevToolsAgentImpl.cpp
    M    WebKit/chromium/src/WebDevToolsAgentImpl.h
    M    WebKit/chromium/src/js/DevToolsHostStub.js
    M    WebKit/chromium/src/js/InspectorControllerImpl.js
Committed r63965