Bug 42831 – Web Inspector: test that inspector will log syntax error in console without crashing

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

Web Inspector: test that inspector will log syntax error in console without crashing

[Yury Semikhatsky]

Created attachment 62306 [details]
Patch

[Joseph Pecoraro]

Cool. Are Syntax Error messages likely to be the same between JSC and V8
or could there be platform specific results?

[Ojan Vafai]

Comment on attachment 62306 [details]
Patch

> +resources/syntax-error.js:1SyntaxError: Parse error

The lack of space between "1" and "SyntaxError" looks strange. Is that a bug (obviously not from this patch though)?

[WebKit Commit Bot]

Comment on attachment 62306 [details]
Patch

Clearing flags on attachment: 62306

Committed r63922: <http://trac.webkit.org/changeset/63922>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Yury Semikhatsky]

(In reply to comment #2)
> Cool. Are Syntax Error messages likely to be the same between JSC and V8
> or could there be platform specific results?

In this patch I'm providing VM-specific results. There is a long discussion of the error message differences between JSC and V8 and it was agreed that they should eventually converge. There is a bug for that problem: https://bugs.webkit.org/show_bug.cgi?id=42181

(In reply to comment #3)
> (From update of attachment 62306 [details])
> > +resources/syntax-error.js:1SyntaxError: Parse error
> 
> The lack of space between "1" and "SyntaxError" looks strange. Is that a bug (obviously not from this patch though)?

It's just a textContent of a DOM element representing the message in Web Inspector UI. Although there is no space in the text dump, there is one in the DOM UI and the message there looks nice. I don't thing we need to fix the text output since it's used only in the tests and it already gives a clear view of the logged message text.