Bug 42793 - editing/execCommand/hilitecolor.html and editing/style/remove-underline-from-stylesheet.html should be dumpAsMarkup tests
Summary: editing/execCommand/hilitecolor.html and editing/style/remove-underline-from-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Blocker
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 27156 39989
  Show dependency treegraph
 
Reported: 2010-07-21 15:53 PDT by Ryosuke Niwa
Modified: 2010-07-24 15:20 PDT (History)
6 users (show)

See Also:


Attachments
converts the tests. (15.26 KB, patch)
2010-07-23 23:45 PDT, Ryosuke Niwa
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-07-21 15:53:17 PDT
The following tests should be using dumpAsMarkup
editing/execCommand/hilitecolor.html
editing/style/remove-underline-from-stylesheet.html
editing/undo/redo-style.html
Comment 1 Ryosuke Niwa 2010-07-23 23:33:26 PDT
Turned out that editing/undo/redo-style.html doesn't need to be converted since it's already a dumpAsText test and the output doesn't rely on the DOM or a subtree.
Comment 2 Ryosuke Niwa 2010-07-23 23:45:12 PDT
Created attachment 62489 [details]
converts the tests.
Comment 3 Ryosuke Niwa 2010-07-24 15:20:02 PDT
Landed as http://trac.webkit.org/changeset/64013.  Thank you for the responsive review, Darin.