RESOLVED FIXED 42783
Break out "scheme registration" functionality to a SchemeRegistry 
https://bugs.webkit.org/show_bug.cgi?id=42783
Summary Break out "scheme registration" functionality to a SchemeRegistry
Brady Eidson
Reported 2010-07-21 13:43:30 PDT
Break out "scheme registration" functionality to a SchemeRegistry. Currently, SecurityOrigin tracks "stuff" about Schemes that can be programmatically registered. Some of the associations to SecurityOrigin were already kind of loose. To support future WebKit API we'd like to track other special types of schemes that are in no way related to SecurityOrigin. We can model MIMETypeRegistry here, as a central holding tank for all Schemes WebCore/WebKit already know about, as well as giving client apps a way to customize things a bit.
Attachments
Patch (33.10 KB, patch)
2010-07-21 14:08 PDT, Brady Eidson 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2010-07-21 14:08:15 PDT
Created attachment 62229 [details] Patch
Geoffrey Garen
Comment 2 2010-07-21 14:46:35 PDT
Comment on attachment 62229 [details] Patch WebCore/platform/SchemeRegistry.cpp:94 + Boo on two names for the same thing. I would rename "localSchemes" to "localURLSchemes". (Requires a namespace qualification on the return statement.) WebCore/platform/SchemeRegistry.cpp:106 + Seems like these fast cases should assert that they're correct. Something like "ASSERT(localSchemes().contains(X))". r=me
Brady Eidson
Comment 3 2010-07-21 16:20:09 PDT
Committed r63863: <http://trac.webkit.org/changeset/63863>
Note You need to log in before you can comment on or make changes to this bug.