Bug 42768 - [chromium] fast/forms/input-file-directory-upload.html fails on win after r63454
Summary: [chromium] fast/forms/input-file-directory-upload.html fails on win after r63454
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: John Gregg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-21 10:21 PDT by Ojan Vafai
Modified: 2010-07-22 18:00 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.64 KB, patch)
2010-07-21 19:10 PDT, John Gregg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2010-07-21 10:21:10 PDT
Looks like the issue is that the paths have backslashes instead of forward slashes. Does the relevant spec comment on this? I think we should normalize to forward slashes. The web shouldn't need to deal with mixed slashes.
Comment 1 John Gregg 2010-07-21 10:22:01 PDT
Agreed, we should normalize to forward slashes, I'm working on a patch
Comment 2 John Gregg 2010-07-21 19:10:29 PDT
Created attachment 62254 [details]
Patch
Comment 3 WebKit Review Bot 2010-07-21 19:14:14 PDT
Attachment 62254 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/html/HTMLInputElement.cpp:2001:  Missing spaces around /  [whitespace/operators] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Kent Tamura 2010-07-21 22:02:00 PDT
Comment on attachment 62254 [details]
Patch

ok.
Comment 5 WebKit Commit Bot 2010-07-22 10:23:12 PDT
Comment on attachment 62254 [details]
Patch

Rejecting patch 62254 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20707 test cases.
animations/play-state.html -> failed

Exiting early after 1 failures. 123 tests run.
13.24s total testing time

122 test cases (99%) succeeded
1 test case (<1%) had incorrect layout

Full output: http://queues.webkit.org/results/3581339
Comment 6 Ojan Vafai 2010-07-22 10:48:12 PDT
> animations/play-state.html -> failed

This test looks to have gotten flaky recently. Likely from http://trac.webkit.org/changeset/63862/. See http://crbug.com/49920 for more details.
Comment 7 John Gregg 2010-07-22 13:05:29 PDT
Comment on attachment 62254 [details]
Patch

okay if it's just flaky i'll try CQ one more time
Comment 8 WebKit Commit Bot 2010-07-22 14:27:10 PDT
Comment on attachment 62254 [details]
Patch

Clearing flags on attachment: 62254

Committed r63914: <http://trac.webkit.org/changeset/63914>
Comment 9 WebKit Commit Bot 2010-07-22 14:27:16 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 John Gregg 2010-07-22 18:00:18 PDT
Committed r63932: <http://trac.webkit.org/changeset/63932>