Bug 42768 – [chromium] fast/forms/input-file-directory-upload.html fails on win after r63454

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Ojan Vafai]

Looks like the issue is that the paths have backslashes instead of forward slashes. Does the relevant spec comment on this? I think we should normalize to forward slashes. The web shouldn't need to deal with mixed slashes.

[John Gregg]

Agreed, we should normalize to forward slashes, I'm working on a patch

[John Gregg]

Created attachment 62254 [details]
Patch

[WebKit Review Bot]

Attachment 62254 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/html/HTMLInputElement.cpp:2001:  Missing spaces around /  [whitespace/operators] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kent Tamura]

Comment on attachment 62254 [details]
Patch

ok.

[WebKit Commit Bot]

Comment on attachment 62254 [details]
Patch

Rejecting patch 62254 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20707 test cases.
animations/play-state.html -> failed

Exiting early after 1 failures. 123 tests run.
13.24s total testing time

122 test cases (99%) succeeded
1 test case (<1%) had incorrect layout

Full output: http://queues.webkit.org/results/3581339

[Ojan Vafai]

> animations/play-state.html -> failed

This test looks to have gotten flaky recently. Likely from http://trac.webkit.org/changeset/63862/. See http://crbug.com/49920 for more details.

[John Gregg]

Comment on attachment 62254 [details]
Patch

okay if it's just flaky i'll try CQ one more time

[WebKit Commit Bot]

Comment on attachment 62254 [details]
Patch

Clearing flags on attachment: 62254

Committed r63914: <http://trac.webkit.org/changeset/63914>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[John Gregg]

Committed r63932: <http://trac.webkit.org/changeset/63932>