%subj%
Windows with Russian locale.
Created attachment 62183 [details] [patch] initial version.
Comment on attachment 62183 [details] [patch] initial version. This is a workaround, and not the real fix. The real fix is to change to a String formatting function that is locale independent.
(In reply to comment #3) > (From update of attachment 62183 [details]) > This is a workaround, and not the real fix. The real fix is to change to a String formatting function that is locale independent. It is not clear whether String formatting should be changed as a whole because of this use case. The code being fixed is supposed to produce strings compatible with JSON and it is JSON spec that requires numbers to have "." separators. Anyways, the fix is incomplete.
Comment on attachment 62183 [details] [patch] initial version. Ok, given that 0.5 will be formatted Ok we should land this.
As Darin said, String formatting needs to be fixed - see also bug 18994. This is a rather poor workaround - it fixes Russian locale, but a locale can use almost arbitrary formatting for numbers. In particular, even proper Russian formatting "(123.456.789,00) will remain broken.
(In reply to comment #6) > As Darin said, String formatting needs to be fixed - see also bug 18994. > > This is a rather poor workaround - it fixes Russian locale, but a locale can use almost arbitrary formatting for numbers. In particular, even proper Russian formatting "(123.456.789,00) will remain broken. We should document all occurences of work arounds for the string formating problems. So we can fix them all at once. Otherwise, adding all this br's on bug 18994 is also some kind of documentation.
(In reply to comment #6) > As Darin said, String formatting needs to be fixed - see also bug 18994. > > This is a rather poor workaround - it fixes Russian locale, but a locale can use almost arbitrary formatting for numbers. In particular, even proper Russian formatting "(123.456.789,00) will remain broken. According to spec %f doesn't uses thousands separator. It will be the problem if some locale uses something different as decimal separator.
already landed
(In reply to comment #8) > (In reply to comment #6) > > As Darin said, String formatting needs to be fixed - see also bug 18994. > > > > This is a rather poor workaround - it fixes Russian locale, but a locale can use almost arbitrary formatting for numbers. In particular, even proper Russian formatting "(123.456.789,00) will remain broken. > > According to spec %f doesn't uses thousands separator. > It will be the problem if some locale uses something different as decimal separator. I guess this is what ap tried to mention. :-P We have many localas with this schema (points and commas in a float). This fix is a hack, that works for some locals, but many still fail, or will fail now. It's sad that there was no FIXME added in the patch. Normaly this patch shouldn't be in trunk. :-(
yep. it should be fixed another way. https://bugs.webkit.org/show_bug.cgi?id=43832