RESOLVED FIXED 42747
build-webkit should build MiniBrowser 
https://bugs.webkit.org/show_bug.cgi?id=42747
Summary build-webkit should build MiniBrowser
Adam Roben (:aroben)
Reported 2010-07-21 06:26:22 PDT
build-webkit should build MiniBrowser
Attachments
Patch (3.35 KB, patch)
2010-07-21 06:27 PDT, Adam Roben (:aroben) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-07-21 06:27:34 PDT
Created attachment 62174 [details] Patch
Darin Adler
Comment 2 2010-07-21 08:17:47 PDT
Comment on attachment 62174 [details] Patch Why does MiniBrowser depend on WebKitTestRunner? They should be two independent projects, both depending on WebKit, right?
Adam Roben (:aroben)
Comment 3 2010-07-21 08:34:32 PDT
(In reply to comment #2) > (From update of attachment 62174 [details]) > Why does MiniBrowser depend on WebKitTestRunner? They should be two independent projects, both depending on WebKit, right? We require the project dependency tree to be linear so that our "stop the build when any project fails" logic will work. MiniBrowser has no build-time or run-time dependency on WebKitTestRunner, but we mark it as depending on WebKitTestRunner so that Visual Studio won't try to build the two projects in parallel. (Unfortunately, this defeats Visual Studio's project-parallel compilation feature. Fortunately, pdevenv's file-parallel compilation feature mitigates this issue.)
Adam Roben (:aroben)
Comment 4 2010-07-21 09:06:38 PDT
Committed r63827: <http://trac.webkit.org/changeset/63827>
Note You need to log in before you can comment on or make changes to this bug.