Bug 42747 - build-webkit should build MiniBrowser
Summary: build-webkit should build MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-21 06:26 PDT by Adam Roben (:aroben)
Modified: 2010-07-21 09:06 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.35 KB, patch)
2010-07-21 06:27 PDT, Adam Roben (:aroben) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-07-21 06:26:22 PDT 
build-webkit should build MiniBrowser
Comment 1 Adam Roben (:aroben) 2010-07-21 06:27:34 PDT 
Created attachment 62174 [details]
Patch
Comment 2 Darin Adler 2010-07-21 08:17:47 PDT 
Comment on attachment 62174 [details]
Patch

Why does MiniBrowser depend on WebKitTestRunner? They should be two independent projects, both depending on WebKit, right?
Comment 3 Adam Roben (:aroben) 2010-07-21 08:34:32 PDT 
(In reply to comment #2)
> (From update of attachment 62174 [details])
> Why does MiniBrowser depend on WebKitTestRunner? They should be two independent projects, both depending on WebKit, right?

We require the project dependency tree to be linear so that our "stop the build when any project fails" logic will work. MiniBrowser has no build-time or run-time dependency on WebKitTestRunner, but we mark it as depending on WebKitTestRunner so that Visual Studio won't try to build the two projects in parallel. (Unfortunately, this defeats Visual Studio's project-parallel compilation feature. Fortunately, pdevenv's file-parallel compilation feature mitigates this issue.)
Comment 4 Adam Roben (:aroben) 2010-07-21 09:06:38 PDT 
Committed r63827: <http://trac.webkit.org/changeset/63827>