WebKit on Windows should build optionally with an unversioned ICU DLL
Created attachment 62142 [details] Patch
Created attachment 62143 [details] Patch
Comment on attachment 62143 [details] Patch Is there a reason to force the include of ICUVersion.h rather than having the project prefix header include it explicitly?
It could probably be moved to <wtf/Platform.h>. That's where we include QuartzCorePresent.h, which is somewhat similar to this. The reason the patch puts it in vcproj/vsprops files is that I needed to edit those files for this patch anyway, so I figured I'd keep the changes localized. This change will be rolled out once we have the new unversioned ICU in the tree.
Comment on attachment 62143 [details] Patch > + Since the versioned and unversioned ICU have different filenames (libicuuc.lib vs icuuc.lib) > + we copy the ICU lib to an intermediate location under obj with a common name. I think you meant "under lib". It would be nicer to add a new ICU.vsprops file that contains the ICU-specific settings (AdditionalDependencies, AdditionalLibraryDirectories, VCPreLinkEventTool, ForcedIncludes). Then each project that links against ICU could just include it. r=me
Comment on attachment 62143 [details] Patch Is this patch still current?
(In reply to comment #6) > (From update of attachment 62143 [details]) > Is this patch still current? No, it was landed in r63833.