Bug 42715 - [chromium] by default, dumpAsText should disable pixel results
Summary: [chromium] by default, dumpAsText should disable pixel results
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-20 16:36 PDT by Tony Chang
Modified: 2010-07-20 18:29 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.42 KB, patch)
2010-07-20 16:37 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-07-20 16:36:39 PDT
[chromium] by default, dumpAsText should disable pixel results
Comment 1 Tony Chang 2010-07-20 16:37:26 PDT
Created attachment 62133 [details]
Patch
Comment 2 Tony Chang 2010-07-20 16:38:47 PDT
This matches the behavior here: http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/LayoutTestController.cpp#L107
Comment 3 Kent Tamura 2010-07-20 18:10:28 PDT
Comment on attachment 62133 [details]
Patch

Oh, this is why we have a lot of MISSING failures.
http://trac.webkit.org/changeset/63536 made this problem.
Comment 4 WebKit Commit Bot 2010-07-20 18:29:26 PDT
Comment on attachment 62133 [details]
Patch

Clearing flags on attachment: 62133

Committed r63796: <http://trac.webkit.org/changeset/63796>
Comment 5 WebKit Commit Bot 2010-07-20 18:29:31 PDT
All reviewed patches have been landed.  Closing bug.